void-packages icon indicating copy to clipboard operation
void-packages copied to clipboard

xbps-src: Don't unset IFS

Open heindsight opened this issue 1 year ago • 1 comments

If IFS is unset, the shell behaves as if it has the default value of <space><tab><newline>. However, after unsetting IFS, constructs like

OFS="$IFS"; IFS=','
...
IFS="$OIFS"

(for example in common/xbps-src/shutils/common.sh lines 246-253) have the effect of setting IFS with an empty value, which breaks word-splitting. This results in an error like

./common/xbps-src/shutils/bulk.sh: line 125: sudo /bin/sh -c: No such file or directory

when running ./xbps-src update-sys with XBPS_SUCMD set to the default value (sudo /bin/sh -c).

Testing the changes

  • I tested the changes in this PR: yes

heindsight avatar Jan 28 '24 14:01 heindsight

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

github-actions[bot] avatar May 09 '24 01:05 github-actions[bot]