void-linux
New package: swaylock-effects-1.7.0.0
Testing the changes
- I tested the changes in this PR: YES
New package
- This new package conforms to the package requirements: YES
Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- i686 (X)
- i686-musl (X)
- x86_64-musl (X)
- armv6l (X)
- armv6l-musl (X)
Opening as draft to discuss possible security concerns previously mentioned by @ericonr (https://github.com/void-linux/void-packages/pull/26392#issuecomment-883685280, https://github.com/void-linux/void-packages/pull/27971#pullrequestreview-570102279). This version is a fork of the now unmaintained original. The maintainer is active, and the current version of jirutka/swaylock-effects is behind swaywm/swaylock by 23 commits. Happy to discuss :)
Also, regarding the template, I'm not sure if it's preferred to have conflicts or replaces? I've gone for the former because the latter would require changing the swaylock template too.
This is a fork of a fork of swaylock. What benefits would this confer, and why chooose this particular fork?
This is a fork of a fork of swaylock. What benefits would this confer, and why chooose this particular fork?
The changes are aesthetic with subjectively 'nicer' screenlocking, so I think I'd be hard pressed to say truthfully there are any benefits, per-se.
As for why this fork, unlike the repo it is forked from (from which people have made the previous PRs), it's being maintained and developed (albeit slowly).
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.
My 5 cents: I think @ericonr 's comment from the closed PR is still valid and personally I concur with @ahesford (there are no benefits, imho)
Last commit was on Dec 30, 2023.
My 5 cents: I think @ericonr 's comment from the closed PR is still valid and personally I concur with @ahesford (there are no benefits, imho)
Last commit was on Dec 30, 2023.
That's fair: I hadn't seen that issue. I'll close this PR.