void-packages icon indicating copy to clipboard operation
void-packages copied to clipboard

New package: msitools-0.103

Open elbeardmorez opened this issue 2 years ago • 8 comments

Testing the changes

  • I tested the changes in this PR: YES

New package

Local build testing

  • I built this PR locally for my native architecture, (x86_64-glibc)

elbeardmorez avatar Nov 22 '23 22:11 elbeardmorez

with a few tweaks to the template the aarch64 package is successfully built here locally

is there a requirement to get the package building for every single supported architecture?

elbeardmorez avatar Nov 30 '23 08:11 elbeardmorez

with a few tweaks to the template the aarch64 package is successfully built here locally

is there a requirement to get the package building for every single supported architecture?

No, but all officially supported architectures by the project itself should likely be functional here too.

Bnyro avatar Dec 03 '23 14:12 Bnyro

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

github-actions[bot] avatar Mar 03 '24 01:03 github-actions[bot]

There is no official list of what it should compile on and trying to compile such a list of potential architectures just in case someone needs it one day doesn't appeal as an exercise. If, assuming this goes in, someone then comes and suggests a tweak to make it also compile on XYZ then cool, I'll push the change.

elbeardmorez avatar Mar 03 '24 12:03 elbeardmorez

I made #49528 as an update to #43321 (which was never merged) and didn't realize this existed. Comparing against your additions, I see that you have build_options="gir" and don't have python3-setuptools.

I found that I needed python3-setuptools otherwise distutils (removed in python 3.12) was missing, and it's used by gobject-introspection. Obviously gobject-introspection should have this dependency itself (EDIT: it appears it does??), but I'm wondering whether the build_options="gir" somehow avoided this issue for you? Or maybe my (previously completely clean) build env somehow got busted?

afranchuk avatar Mar 27 '24 14:03 afranchuk

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

github-actions[bot] avatar Jun 26 '24 01:06 github-actions[bot]

bump!!

@afranchuk did you ever attempt any cross compilation?

I'm not able to comment authoritatively on the gobject-introspection line of questioning, but if I recall correctly, having hit a build failure due to that requirement itself, hunting led me to the likes of https://voidlinux.org/news/2019/02/cross-gobject.html and with the requirement to test cross-compilation (where possible), and having made comparisons with other package's build config / template files, the build_options="gir" addition was the winner.

Given that that post gives me the getting this sh1t working on the myriad platforms packages are available for in the voidlinux arena is difficult so this is how we do it going forward vibe.. I do not want to dig at this at all.

@Bnyro are there any further steps that you are expecting here? @afranchuk has tried twice to get this in, myself just the once, it's not a very complex package so it would be good to understand how we can make this happen.

elbeardmorez avatar Jun 26 '24 08:06 elbeardmorez

I did not try any cross-compilation. But I agree, it'd be nice to know why this package stagnates.

afranchuk avatar Jun 26 '24 12:06 afranchuk