void-packages icon indicating copy to clipboard operation
void-packages copied to clipboard

New package: monophony-2.10.0 and dependencies

Open Bnyro opened this issue 2 years ago • 9 comments

Testing the changes

  • I tested the changes in this PR: YES

New package

Local build testing

  • I built this PR locally for my native architecture, x86_64-glibc
  • I built this PR locally for these architectures:
    • i686

Bnyro avatar Aug 04 '23 13:08 Bnyro

Hey @zehkira, what's the state of Python3.12 for Monophony?

When compiling, I get

Nuitka-Reports:INFO: Compilation report written to file 'nuitka-crash-report.xml'.
Traceback (most recent call last):
  File "/usr/lib/python3.12/site-packages/nuitka/__main__.py", line 155, in <module>
    main()
  File "/usr/lib/python3.12/site-packages/nuitka/__main__.py", line 141, in main
    MainControl.main()
  File "/usr/lib/python3.12/site-packages/nuitka/MainControl.py", line 1093, in main
    _main()
  File "/usr/lib/python3.12/site-packages/nuitka/MainControl.py", line 962, in _main
    result, options = compileTree()
                      ^^^^^^^^^^^^^
  File "/usr/lib/python3.12/site-packages/nuitka/MainControl.py", line 836, in compileTree
    makeSourceDirectory()
  File "/usr/lib/python3.12/site-packages/nuitka/MainControl.py", line 437, in makeSourceDirectory
    source_code = CodeGeneration.generateModuleCode(
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/site-packages/nuitka/code_generation/CodeGeneration.py", line 578, in generateModuleCode
    return _generateModuleCode(module=module, data_filename=data_filename)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/site-packages/nuitka/code_generation/CodeGeneration.py", line 538, in _generateModuleCode
    function_code, function_decl = generateFunctionBodyCode(
                                   ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/site-packages/nuitka/code_generation/CodeGeneration.py", line 482, in generateFunctionBodyCode
    function_code = getFunctionCode(
                    ^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/site-packages/nuitka/code_generation/FunctionCodes.py", line 612, in getFunctionCode
    return _getFunctionCode(
           ^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/site-packages/nuitka/code_generation/FunctionCodes.py", line 652, in _getFunctionCode
    generateStatementSequenceCode(
  File "/usr/lib/python3.12/site-packages/nuitka/code_generation/CodeHelpers.py", line 241, in generateStatementSequenceCode
    _generateStatementSequenceCode(
  File "/usr/lib/python3.12/site-packages/nuitka/code_generation/CodeHelpers.py", line 230, in _generateStatementSequenceCode
    generateStatementCode(
  File "/usr/lib/python3.12/site-packages/nuitka/code_generation/CodeHelpers.py", line 190, in generateStatementCode
    statement_dispatch_dict[statement.kind](
  File "/usr/lib/python3.12/site-packages/nuitka/code_generation/TryCodes.py", line 86, in generateTryCode
    generateStatementSequenceCode(
  File "/usr/lib/python3.12/site-packages/nuitka/code_generation/CodeHelpers.py", line 241, in generateStatementSequenceCode
    _generateStatementSequenceCode(
  File "/usr/lib/python3.12/site-packages/nuitka/code_generation/CodeHelpers.py", line 225, in _generateStatementSequenceCode
    generateStatementsFrameCode(
    getFrameGuardHeavyCode(
  File "/usr/lib/python3.12/site-packages/nuitka/code_generation/FrameCodes.py", line 311, in getFrameGuardHeavyCode
    renderTemplateFromString(
  File "/usr/lib/python3.12/site-packages/nuitka/utils/Jinja2.py", line 140, in renderTemplateFromString
    _template_cache[template_str] = getTemplateFromString(template_str)
                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/site-packages/nuitka/utils/Jinja2.py", line 129, in getTemplateFromString
    return getEnvironment(
           ^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/site-packages/nuitka/utils/Jinja2.py", line 77, in getEnvironment
    jinja2 = getJinja2Package()
             ^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/site-packages/nuitka/utils/Jinja2.py", line 62, in getJinja2Package
    _loaded_pkg_resources = importFromInlineCopy("pkg_resources", must_exist=False)
                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/site-packages/nuitka/utils/Importing.py", line 184, in importFromInlineCopy
    return _importFromFolder(
           ^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/site-packages/nuitka/utils/Importing.py", line 147, in _importFromFolder
    return __import__(module_name, level=0)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/site-packages/nuitka/build/inline_copy/pkg_resources/pkg_resources/__init__.py", line 2191, in <module>
    register_finder(pkgutil.ImpImporter, find_on_path)
                    ^^^^^^^^^^^^^^^^^^^
AttributeError: module 'pkgutil' has no attribute 'ImpImporter'. Did you mean: 'zipimporter'?

Bnyro avatar Oct 31 '23 16:10 Bnyro

Nuitka does not support Python 3.12 yet.

ghost avatar Oct 31 '23 19:10 ghost

I assume there's no way to use monophony without compiling via Nuitka currently? It would be handy if it could be installed like any other Python module instead of being compiled first.

Bnyro avatar Oct 31 '23 19:10 Bnyro

You could patch the Makefile and the pyproject.toml to install it as a module. I don't recommend doing that though.

ghost avatar Oct 31 '23 19:10 ghost

Okay, we'll wait for Nuitka to support Py3.12 then. Thanks for the answers!

Bnyro avatar Oct 31 '23 19:10 Bnyro

As discussed in https://github.com/void-linux/void-packages/issues/47982, nuitka does not appear to be suitable for packaging on Void.

ahesford avatar Dec 30 '23 00:12 ahesford

Closing for the given reasons.

Bnyro avatar Jan 17 '24 18:01 Bnyro

Starting with the upcoming v2.10.0 release, Monophony will no longer use Nuitka.

ghost avatar May 11 '24 16:05 ghost

That's awesome, I'll give this PR an other shot once it's released 🚀

Bnyro avatar May 11 '24 19:05 Bnyro

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

github-actions[bot] avatar Aug 26 '24 01:08 github-actions[bot]