void-packages icon indicating copy to clipboard operation
void-packages copied to clipboard

New package: josm-19439

Open TinfoilSubmarine opened this issue 2 years ago • 15 comments

Testing the changes

  • I tested the changes in this PR: YES

New package

TinfoilSubmarine avatar Jul 20 '23 16:07 TinfoilSubmarine

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

github-actions[bot] avatar Dec 21 '23 01:12 github-actions[bot]

Builded and installed, but when I launch it:

Using /usr/lib/jvm/openjdk17/bin/java to execute josm.
Error occurred during initialization of boot layer
java.lang.module.FindException: Module javafx.web not found

Emru1 avatar Jul 31 '24 08:07 Emru1

Launching it manually, without this debian scipt installed in /usr/bin/josm works properly

Emru1 avatar Jul 31 '24 09:07 Emru1

Could you try with the latest version I just pushed? It has a patch that strips out the Debian-specific stuff from /usr/bin/josm. That is the only change I made.

TinfoilSubmarine avatar Aug 01 '24 15:08 TinfoilSubmarine

...which of course means we should just be using Void's canonical way of finding the correct jre, which is of course just using the java available on path, which is what you were saying in the first place. I'll update this to just do that when I get a chance instead of using the unnecessary included script.

TinfoilSubmarine avatar Aug 02 '24 03:08 TinfoilSubmarine

now it works :)

Emru1 avatar Aug 11 '24 16:08 Emru1

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

github-actions[bot] avatar Nov 10 '24 02:11 github-actions[bot]

bump

Emru1 avatar Nov 10 '24 08:11 Emru1

bump

TinfoilSubmarine avatar Jan 21 '25 13:01 TinfoilSubmarine

I've tested it, it works but, I'm getting message about using java version that soon will be deprecated josm has booted with 11, I have also 17 and 21 installed, but it's not using it by default Is there a way for josm to use newer java by default? Maybe some changes in the boot script?

Emru1 avatar Mar 18 '25 07:03 Emru1

Currently it uses whatever jdk is set by xbps-alternatives.

TinfoilSubmarine avatar Mar 18 '25 13:03 TinfoilSubmarine

Using the xbps virtual?java-runtime is imperfect since we depend on at least 11, meaning it would break if the user tried to use openjdk8. But there is no way to specify a version guard with the virtual dependency. Probably the best solution is to hard depend on one version of java.

TinfoilSubmarine avatar Mar 18 '25 13:03 TinfoilSubmarine

I pushed an updated version that depends directly on openjdk17-jre. Please test if you can.

TinfoilSubmarine avatar Mar 19 '25 12:03 TinfoilSubmarine

I pushed an updated version that depends directly on openjdk17-jre. Please test if you can.

This has been working fine for me in my testing.

TinfoilSubmarine avatar Apr 12 '25 21:04 TinfoilSubmarine

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

github-actions[bot] avatar Dec 09 '25 02:12 github-actions[bot]