void-linux
sane: fix PDF-producing eSCL scanners failing with `Invalid argument`
eSCL-speaking scanners that produce PDF-formatted output scan properly, but completion is only met with sane_start: Invalid argument expressed in various forms depending on front-end.
This is due to SANE being built without PDF support, provided by poppler-glib; this commit enables that as a default-on option, fixing support for those scanners.
Testing the changes
- I tested the changes in this PR: YES (using an EPSON XP-325)
how can i get at least a test-version of the new package? i think my scanner (Canon PIXMA TS3450) delivers PDF, too...
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Gave up trying to understand precisely why the test fails. Not surprising it would really be broken upstream considering its sorry state on 32 bit for 4 years now.
So I just disabled tests when poppler is enabled too.
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.
Again, this is still current, and SANE's test situation has not improved since 90 days.
why cant we just do it? i mean: make a new package? when i compile&install it myself, it works fine...
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.
More than a year later, it seems this has not been looked at by any maintainer.
I'll ping @Piraty since they were the one to touch this file through a PR merge that updated sane to the current 1.2.1.
a gentle ping usually works best ;) (template mentions me as maintainer= , so pinging me would have been wise from the start)
thanks for this patch!
- commit title is too verbose, something like `sane: enable pdf support' will work just fine.
- since poppler build option is not part of
common/options.description, you should declaredesc_option_poppler=like texstudio's template does
@Piraty Oooh thanks a lot for these suggestions; I had noticed that options have their common description file back then but wasn't sure if I should touch it, and I found no documentation on whether one could create a per-package option, thanks again for the tip.
I've also shortened the commit name, as you suggested.