void-packages icon indicating copy to clipboard operation
void-packages copied to clipboard

python3-sh: update to 1.14.3.

Open pfpulux opened this issue 3 years ago • 6 comments

Testing the changes

  • I tested the changes in this PR: YES

pfpulux avatar Aug 10 '22 05:08 pfpulux

The failing test is weird. It always fails for me when run on a clean build but passes on subsequent invocations.

icp1994 avatar Aug 10 '22 19:08 icp1994

I wonder what dir it's listing for this

https://github.com/amoffat/sh/blob/develop/test.py#L862-L866

classabbyamp avatar Aug 11 '22 04:08 classabbyamp

masterdir/tmp is being operated on. Both ls -A1 and os.listdir(".") outputs the contents properly. Even if you manually wipe with rm -r masterdir/tmp/*, on a clean build you get AssertionError: 1 != 0. But wiping tmp and running ./xbps-src check again passes immediately after that :confounded:

icp1994 avatar Aug 11 '22 19:08 icp1994

maybe another test is creating files in tmp?

classabbyamp avatar Aug 11 '22 19:08 classabbyamp

It does generate 2 files under masterdir/tmp for me after each invocation but that happens in later tests, executed after the two function calls in this test. Even then I couldn't figure out a reason why it would pass the tests on rebuilds with an empty tmp since the conditions seem identical to a clean build. Might just be that test has some race condition or flaky or weird issue with ls and wc.

icp1994 avatar Aug 12 '22 16:08 icp1994

ok, let's disable this test then.

classabbyamp avatar Aug 12 '22 16:08 classabbyamp

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

github-actions[bot] avatar Nov 11 '22 02:11 github-actions[bot]