void-packages icon indicating copy to clipboard operation
void-packages copied to clipboard

New package: wayshot-1.1.9

Open akhiljalagam opened this issue 3 years ago • 1 comments

Testing the changes

  • I tested the changes in this PR: YES

New package

akhiljalagam avatar Aug 09 '22 05:08 akhiljalagam

oops. found a duplicate https://github.com/void-linux/void-packages/pull/36000

akhiljalagam avatar Aug 09 '22 05:08 akhiljalagam

Hi! apologies for the issues. I have tagged a release with the scdoc man pages ❤️

Shinyzenith avatar Sep 05 '22 12:09 Shinyzenith

Another thing that I should mention, the build.rs file compiles the man pages automatically if the scdoc binary is found on the build container 😁.

Shinyzenith avatar Sep 05 '22 12:09 Shinyzenith

why it's taking this much time to complete the build? @classabbyamp

akhiljalagam avatar Sep 05 '22 13:09 akhiljalagam

why it's taking this much time to complete the build? @classabbyamp

I'm afraid I know why....I'll tag a release with fix when I get home...my apologies once again. Basically I did a scdoc check in build.rs and it inherited the stdio of parent process and kept waiting for input.

Shinyzenith avatar Sep 05 '22 20:09 Shinyzenith

https://github.com/waycrate/wayshot/releases/tag/1.2.1 fixed!

Shinyzenith avatar Sep 06 '22 03:09 Shinyzenith

https://github.com/waycrate/wayshot/releases/tag/1.2.1 fixed!

thanks. it worked finally. but the man pages are installed only when used shell redirection. I think the way void build rust packages is different.

akhiljalagam avatar Sep 06 '22 04:09 akhiljalagam

the man pages are installed only when used shell redirection

$ ./xbps-src build wayshot
...
$ ls masterdir/builddir/wayshot-1.2.1/docs
assets  wayshot.1.gz  wayshot.1.scd  wayshot.7.gz  wayshot.7.scd
$ file masterdir/builddir/wayshot-1.2.1/docs/wayshot.1.gz 
masterdir/builddir/wayshot-1.2.1/docs/wayshot.1.gz: troff or preprocessor input, ASCII text

@Shinyzenith it's still broken, you're writing uncompressed manpages but calling them gzipped

@akhiljalagam you shouldn't need to build them with scdoc yourself, they build properly because build.rs always runs for the host, not target, on cross. once this other issues is fixed they should be vmanable (or even possible now if you rename them)

classabbyamp avatar Sep 06 '22 05:09 classabbyamp

Understood. I will remove manual scdoc cmds then.
@Shinyzenith once you do the fix, I can release with the required changes.

akhiljalagam avatar Sep 06 '22 05:09 akhiljalagam

Okay! I'll export them as *.1 files and gzip them! Will do it asap.

Shinyzenith avatar Sep 06 '22 06:09 Shinyzenith

Done!

Shinyzenith avatar Sep 07 '22 19:09 Shinyzenith

Done!

release 1.2.2 also not installing man pages automatically.

akhiljalagam avatar Sep 08 '22 05:09 akhiljalagam

Done!

release 1.2.2 also not installing man pages automatically.

We don't install the man pages, we just transpile and gzip them programmatically. Isn't that supposed to be done on the package side ?

Shinyzenith avatar Sep 08 '22 06:09 Shinyzenith

@Shinyzenith oh. got it now. thanks.

akhiljalagam avatar Sep 08 '22 06:09 akhiljalagam

done. tested 1.2.2. working now.

akhiljalagam avatar Sep 08 '22 06:09 akhiljalagam

buiild failed for musl with fololowing error ERROR: [trans] failed to download libllvm12-12.0.1_3' signature from https://repo-ci.voidlinux.org/current/musl': Not Found

akhiljalagam avatar Sep 15 '22 06:09 akhiljalagam

Your template almost works, just remove the scdoc commands from the post_install - it should be:

post_install() {
	vlicense LICENSE
	vman docs/wayshot.1.gz
	vman docs/wayshot.7.gz
}

icp1994 avatar Sep 21 '22 16:09 icp1994

Hi! just curious, is anything blocking this that's supposed to be fixed upstream?

Shinyzenith avatar Oct 06 '22 09:10 Shinyzenith

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

github-actions[bot] avatar Jan 05 '23 01:01 github-actions[bot]

Hi! just curious, is anything blocking this that's supposed to be fixed upstream?

void linux needs more volunteers

akhiljalagam avatar Jan 19 '23 04:01 akhiljalagam