void-packages icon indicating copy to clipboard operation
void-packages copied to clipboard

hplip: update to 3.22.6. + new hplip-plugin

Open biopsin opened this issue 3 years ago • 2 comments

Testing the changes

  • I tested the changes in this PR: YES
  • Remove 1 patch and add 1 build dependency
  • Tested both packages with hplip-scan & xsane on HP Neverstop Laser MFP 120x.
  • Continue from PR #35611
  • Close issue #34845

biopsin avatar May 25 '22 07:05 biopsin

@biopsin Forgot to fix #https://github.com/void-linux/void-packages/issues/34845#issuecomment-1007286087

biopsin avatar May 25 '22 08:05 biopsin

uhm this is awkward as I expected both 40-libsane.rules & S99-2000S1.rules to be in the sane package but xlocate sane.rules only locates 49-sane.rules file, so something is later on creating these or what?

biopsin avatar May 28 '22 07:05 biopsin

Hey @paper42,

does this PR need some work or is it good to go?

Since I don't know which void-linux team member to ask, I just choose you randomly. I hope you don't mind. When there is a better way of getting attention for a specific PR please let me know. :slightly_smiling_face:

dataCobra avatar Aug 14 '22 08:08 dataCobra

I don't know anything about this package and I never touched it, so I can't review this and don't feel comfortable blindly merging this.

paper42 avatar Aug 14 '22 12:08 paper42

I don't know anything about this package and I never touched it, so I can't review this and don't feel comfortable blindly merging this.

@paper42, thank you for taking the time to check the PR anyway. :slightly_smiling_face: :+1:

dataCobra avatar Aug 14 '22 12:08 dataCobra

Hey @biopsin,

do you have the time to get the PR further?

If you need help I'll try to assist you. :+1:

dataCobra avatar Aug 14 '22 12:08 dataCobra

Hi @dataCobra jup will resolve my mistakes later today, please test against your hardware would be nice

biopsin avatar Aug 14 '22 13:08 biopsin

I'll test after your changes. :)

dataCobra avatar Aug 14 '22 14:08 dataCobra

Hey @biopsin,

are you able to fix the issues?

dataCobra avatar Sep 05 '22 18:09 dataCobra

@dataCobra Please take over as I see I wont make it in reasonable time at the moment. I also wanted to fix the sane pkg -> 49-sane.rules file but it should be in own PR. Sorry for the lag

biopsin avatar Sep 06 '22 16:09 biopsin

@biopsin I've created two new PRs. You can close this one if you want.

You are named as the maintainer of the hplip-plugin package. I'll not change this.

dataCobra avatar Sep 07 '22 08:09 dataCobra

Hey @biopsin, are you able to close here?

dataCobra avatar Sep 21 '22 08:09 dataCobra