Issue with --make-rshared /

[prog-r-amer]

Hi, I made a reddit post yesterday where I wrote that mklive.sh messed up my bootloader after I deleted the folder generated from void-mklive. I now found out what the issue was.

I have

mount --make-rshared / in my /etc/rc.local.

After using mount --make-rprivate / everything worked flawlessly.

Now my question: Would it make sense to add a check for how / is mounted, and if so are pull requests welcome?

[Vaelatern]

How did rshared cause this?

[prog-r-amer]

The unmounting failed, and I deleted the folder with sudo rm -rf

[Vaelatern]

What kind of solution do you propose here?

[prog-r-amer]

Maybe something that checks if / is shared via something like findmnt -o PROPAGATION /, but that might be too specific and only to my specific usererror. Or otherwise just a simple text message in the die function like: Care when deleting this folder, it might have unwanted side effects.

It could be that both of those are not the void way though, I just wanted to leave it to discussion. Also now people who do the same shit as me find something when they google it and don't leave a bug report :)

[classabbyamp]

i think we just need to --make-rslave or something so it unmounts properly