void-mklive icon indicating copy to clipboard operation
void-mklive copied to clipboard

installer doesn't allow creation of user with no secondary groups

Open tanishyadav opened this issue 1 year ago • 1 comments

validate_useraccount() {
    # don't check that USERNAME has been set because it can be empty
    local USERLOGIN=$(get_option USERLOGIN)
    local USERPASSWORD=$(get_option USERPASSWORD)
    local USERGROUPS=$(get_option USERGROUPS)

    if [ -n "$USERLOGIN" ] && [ -n "$USERPASSWORD" ] && [ -n "$USERGROUPS" ]; then
        USERACCOUNT_DONE=1
    fi
}

The above check (in installer.sh) prevents creation of user without secondary groups. I think USERGROUPS can be left unchecked like USERNAME.

tanishyadav avatar Mar 01 '24 06:03 tanishyadav

creating a user with no other groups is inadvisable. you should at minimum have the user be a member of wheel and maybe users

classabbyamp avatar Mar 12 '24 14:03 classabbyamp