void-containers icon indicating copy to clipboard operation
void-containers copied to clipboard

.github/workflows/build: enable pushing to dockerhub

Open classabbyamp opened this issue 2 years ago • 6 comments

despite dockerhub's checkered recent past, I think this is beneficial, especially as alpha.de's DNS no longer works, breaking people who use the current dockerhub container as-is. If we do this, we should be able to remove the old images and direct people to the new ones.

This will require dockerhub credentials be added as secrets.

classabbyamp avatar Oct 30 '23 15:10 classabbyamp

we should also consider removing the old ghcr images so people migrate to the updated ones:

  • https://github.com/orgs/void-linux/packages/container/package/void-linux
  • https://github.com/orgs/void-linux/packages/container/package/docker-bootstrap

classabbyamp avatar Oct 30 '23 15:10 classabbyamp

Perhaps explicitly mention docker.io (iirc), so it's clear where it pushes.

leahneukirchen avatar Oct 30 '23 16:10 leahneukirchen

Is there a discussion I missed which speaks against merging this?

Anachron avatar Mar 09 '24 09:03 Anachron

not really

classabbyamp avatar Mar 09 '24 09:03 classabbyamp

Still not sure why this is not being merged.

Is this just a "lets wait if something comes up against it" or do we actually need someone else to approve it?

Anachron avatar Aug 07 '24 05:08 Anachron

probably because we've been doing other things

classabbyamp avatar Aug 07 '24 05:08 classabbyamp