so-vits-svc-fork
so-vits-svc-fork copied to clipboard
Training past max. epoch
Describe the bug
It appears that there is currently no hard-limit on the max. epoch for the training, meaning it will go past the default 10k epochs (or, 0-9999 rather)

To Reproduce Train to the limit and let it train further
Additional context I'm not sure if there's a method to limit the max. epoch and have it end training at that point automatically, or if we need to handle that ourselves
Looking at the code there clearly is a max_epoch value set, but somehow it isn't considered by the trainer... I'll look into it a bit more
This actually seems to be related to overriding internal variables for the current epoch.
Commenting those out and trying to train a model up to 5 epochs will make it stop after that perfectly fine.

I've opened a discussion thread over on the Lightning repository as well, forgot to mention that. https://github.com/Lightning-AI/lightning/discussions/17396
I might dig more into the internals to see where it's checking against the max epochs and such
Resolved in 3.10.2