Parametrise REVERT_INTERVAL. Cosmetic changes

[alienmind]

[voghDev]

Hi! Thanks for the PR. It looks pretty good, I would remark just a couple of things

• I would not extract the number 8 to a REVERT_INTERVAL variable as it will never change. Facts already happened and the exact time was 8 seconds; I don't think we are going to rewrite the past :-P so there's no need on a variable. I think 1..8 looks more readable than 1..$VAR.
• I think it is funnier to remove the -n option in the echo "." line, so each "." is painted in a different line, and the effect is funnier for the reader.

Let me know what you think

[aqreed]

well...rewriting the past is exactly mr pushdemont expertise...

2017-10-14 14:50 GMT+02:00 Olmo Gallegos [email protected]:

Hi! Thanks for the PR. It looks pretty good, I would remark just a couple of things

• I would not extract the number 8 to a REVERT_INTERVAL variable as it will never change. Facts already happened and the exact time was 8 seconds; I don't think we are going to rewrite the past :-P so there's no need on a variable. I think 1..8 looks more readable than 1..$VAR.
• I think it is funnier to remove the -n option in the echo "." line, so each "." is painted in a different line, and the effect is funnier for the reader.

Let me know what you think

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/voghDev/git-pushdemont/pull/20#issuecomment-336633108, or mute the thread https://github.com/notifications/unsubscribe-auth/AT9pzB_9EtH3XVy5-Em2qYjd7AFOOI-9ks5ssK4bgaJpZM4P5RlH .

[voghDev]

[Update] Still trying to apply your PRs, but for some reason the for loop iterates only once, instead of 8. Only way to make it work is current code: 1 2 3 4 5 6 7 8

I'll keep on trying and let you guys know :)