Daniil Vodopian

Boolean parameters on a call site

10

Boolean parameters in a multi-parameter function (boolean flags) must be marked on a call site to clarify their meaning. In for Kotlin functions use named parameters. For Java functions use...

Platform type for public functions/properties

3

A public function/method returning an expression of a platform type must declare its kotlin type explicitly: ``` fun apiCall(): String = MyJavaApi.getProperty("name") ``` Any property (package-level or class-level) initialised with...

One-liner assignment methods

4

How should a method be formatted which contains a one-line assignment? Use cases: ``` kotlin // mutating methods: var x = 0 fun mutateX(d: Int) { x += d }...

Assignment and a boolean operator

6

In a case of "assignment" syntax with a boolean expression `==` put brackets around the expression: Good: ``` kotlin // assignment: val x: Boolean = (this == other) // expression...

Improve Getting Started in the docs

1

Now instructions for starting using Cordentity are just `gradle clean buil`. Please make a usable guide!

ReadmeExampleTest file (in develop) is a bit weird: val ministry: StartedNode = issuer val alice: StartedNode = alice val store: StartedNode = bob Why is `InternalMockNetwork.MockNode` part needed?

The root readme file contains a weird line: > val ministry: StartedNode val alice: StartedNode val store: StartedNode I think it is a bug GitHub markdown engine, but we still...

`LedgerService` uses retries to combat Indy state instability. Currently it does 5 retries and waits 2000ms on each. How do I lower those parameters to 3 retries 1000ms each?

Here in the documenting comment it says that `createCredentialDefinition` "stores [credential definition] to ledger if not exists", which is not what the implementation is doing. https://github.com/hyperledger-labs/cordentity/blob/3f11d7385363318588cd4c985c6c82035a602643/indy-utils/src/main/kotlin/com/luxoft/blockchainlab/hyperledger/indy/wallet/WalletUser.kt#L179 Probably this is an...

add google account info

1

Just a feature request: It would be really cool to have Google account information (image, +G, Gmail, notifications) in the right top corner, because it was the only useful feature...