rua
rua copied to clipboard
vn971
Add assume-installed #106
Added the ability to specify packages that should be filtered out from the pacman_deps list. makepkg doesn't have a --assume-installed equivalent so if a filter is provided by the user then nodeps is added to the makepkg arguments list.
First time contributing to a rust project. Any feedback is welcome.
What'st the point of this if nodeps is going to be passed to makepkg? Wouldn't it make sense to just implement it as nodeps?
What'st the point of this if nodeps is going to be passed to makepkg? Wouldn't it make sense to just implement it as nodeps?
Well there appears to be two sets of dependency checks happening. One happens within rua and the other happens from makepkg. This patch filters out dependencies on ruas side so that the user isn't prompted to download a package they may already have ( tested by installing paru so in that case, cargo ). Nodeps is then passed to makepkg under the assumption that there aren't additional dependencies in makepkg that rua didn't catch.
I agree that passing nodeps isn't great, however to get this working without passing nodeps you'd have to modify depends and makedepends on the users behalf or have the user go in and manually remove packages from PKGBUILD which is what this was, in part, meant to address. I choose the easier option which is to assume all dependencies were found ( or ignored ) on ruas side and to skip makepkgs dependency checks. All of that said, I'm open to investigating other solutions.
Ah right didn't realize rua didnt resolve the repo deps itself instead of using -i
@The-Corrupted any reasons for closing it? I actually wanted to get back on this in the coming days. Is this no longer relevant, or you lost interest in maintaining the PR / something else?
@vn971 No, sorry. I was cleaning up my github. It was late and I wasn't paying attention. I've reopened it.
Thanks for the reply! I was meditating on the code a little bit this week, not exactly immediately grasping the need, or rather, whether this specific approach would be what users want to have the most. The need itself is completely valid of course, I'm pretty sure it exists, just have to dive into it again and understand the best approach to handle this