github-profile-summary-cards icon indicating copy to clipboard operation
github-profile-summary-cards copied to clipboard

feat: Added exclude argument for languages

Open MiranDaniel opened this issue 2 years ago • 9 comments

Added an optional exclude argument for excluding languages from the cards. Accepts comma separated lists (ex. cpp,java).

MiranDaniel avatar Jul 09 '22 18:07 MiranDaniel

Awesome work! I will review this tomorrow.

vn7n24fzkq avatar Jul 09 '22 18:07 vn7n24fzkq

Do we need those modules in package.json?

"serverless": "^3.20.0",
"vercel-node-server": "^2.2.1"

And if possible, I think we should change the package-lock.json just before release. Everything else looks good to me.

vn7n24fzkq avatar Jul 10 '22 08:07 vn7n24fzkq

My bad, didn't notice those 2 new modules, not needed.

MiranDaniel avatar Jul 10 '22 10:07 MiranDaniel

Thanks! Also, package-lock.json should not be changed, can you revert that?

vn7n24fzkq avatar Jul 10 '22 11:07 vn7n24fzkq

And there are some conflicts in README.md. If it's not trouble for you could you please resolve that?

vn7n24fzkq avatar Jul 10 '22 11:07 vn7n24fzkq

Fixed!

MiranDaniel avatar Jul 12 '22 14:07 MiranDaniel

Thanks! @MiranDaniel Seems package.json got a parsing error, so Tests and Lint cannot pass. I guess because there is an extra comma at the end of "retry-axios": "^2.6.0", We need to remove it. After that, we can merge this PR.

vn7n24fzkq avatar Jul 12 '22 14:07 vn7n24fzkq

Oh, we have some more discussion in #94, need your reply.

vn7n24fzkq avatar Jul 12 '22 14:07 vn7n24fzkq

@MiranDaniel , Hi, do you still working on this? If you are busy, I can help with the rest steps. I think we can merge this after solving the conflict.

vn7n24fzkq avatar Aug 04 '22 16:08 vn7n24fzkq

Hi @MiranDaniel.

Are you still working on this? Since this PR is almost done, if you don't mind I can take over the rest part and keep your commit in the commit history.

vn7n24fzkq avatar Nov 10 '22 03:11 vn7n24fzkq