github-profile-summary-cards
github-profile-summary-cards copied to clipboard
feat: Added exclude argument for languages
Added an optional exclude
argument for excluding languages from the cards. Accepts comma separated lists (ex. cpp,java
).
Awesome work! I will review this tomorrow.
Do we need those modules in package.json
?
"serverless": "^3.20.0",
"vercel-node-server": "^2.2.1"
And if possible, I think we should change the package-lock.json
just before release.
Everything else looks good to me.
My bad, didn't notice those 2 new modules, not needed.
Thanks!
Also, package-lock.json
should not be changed, can you revert that?
And there are some conflicts in README.md
.
If it's not trouble for you could you please resolve that?
Fixed!
Thanks! @MiranDaniel
Seems package.json
got a parsing error, so Tests
and Lint
cannot pass.
I guess because there is an extra comma at the end of "retry-axios": "^2.6.0",
We need to remove it.
After that, we can merge this PR.
Oh, we have some more discussion in #94, need your reply.
@MiranDaniel , Hi, do you still working on this? If you are busy, I can help with the rest steps. I think we can merge this after solving the conflict.
Hi @MiranDaniel.
Are you still working on this? Since this PR is almost done, if you don't mind I can take over the rest part and keep your commit in the commit history.