versatile-data-kit icon indicating copy to clipboard operation
versatile-data-kit copied to clipboard

DRAFT control-service: AWS Code commit integration

Open SurajViitk opened this issue 10 months ago • 4 comments

Just exposing AWS credentials retreived by git to test them for AWS codecommit

EDIT: removed this

SurajViitk avatar Apr 15 '24 08:04 SurajViitk

@SurajViitk, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

vmwclabot avatar Apr 15 '24 08:04 vmwclabot

@SurajViitk, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed.

vmwclabot avatar Apr 15 '24 09:04 vmwclabot

Looks good to me.

@mivanov1988 is one who have worked al ot on job-builder so if he can take a look that would be a bonus.

How did you test it? You can reuse/modify the script to deploy the control service in your own kubernetes and make sure that it works - https://github.com/vmware/versatile-data-kit/blob/main/projects/control-service/cicd/deploy-testing-pipelines-service.sh

antoniivanov avatar Apr 26 '24 07:04 antoniivanov

@SurajViitk, VMware has approved your signed contributor license agreement.

vmwclabot avatar May 16 '24 18:05 vmwclabot