terraform-provider-nsxt icon indicating copy to clipboard operation
terraform-provider-nsxt copied to clipboard

Published 20 hours ago • verified publisher icon vmware

tools: fix policy generation script

Open alagoutte opened this issue 3 years ago • 7 comments

for avoid nsxt/resource_nsxt_policy_mac_discovery_profile.go:135:21: not enough arguments in call to client.Patch have (string, github.com/vmware/vsphere-automation-sdk-go/services/nsxt-gm/model.MacDiscoveryProfile) want (string, github.com/vmware/vsphere-automation-sdk-go/services/nsxt-gm/model.MacDiscoveryProfile, *bool) nsxt/resource_nsxt_policy_mac_discovery_profile.go:138:21: not enough arguments in call to client.Patch have (string, github.com/vmware/vsphere-automation-sdk-go/services/nsxt/model.MacDiscoveryProfile) want (string, github.com/vmware/vsphere-automation-sdk-go/services/nsxt/model.MacDiscoveryProfile, *bool) nsxt/resource_nsxt_policy_mac_discovery_profile.go:240:25: not enough arguments in call to client.Update have (string, github.com/vmware/vsphere-automation-sdk-go/services/nsxt-gm/model.MacDiscoveryProfile) want (string, github.com/vmware/vsphere-automation-sdk-go/services/nsxt-gm/model.MacDiscoveryProfile, *bool) nsxt/resource_nsxt_policy_mac_discovery_profile.go:243:25: not enough arguments in call to client.Update have (string, github.com/vmware/vsphere-automation-sdk-go/services/nsxt/model.MacDiscoveryProfile) want (string, github.com/vmware/vsphere-automation-sdk-go/services/nsxt/model.MacDiscoveryProfile, *bool) nsxt/resource_nsxt_policy_mac_discovery_profile.go:262:22: not enough arguments in call to client.Delete have (string)

alagoutte avatar Dec 24 '21 14:12 alagoutte

@alagoutte, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

vmwclabot avatar Dec 24 '21 14:12 vmwclabot

hi @annakhm can you look ?

alagoutte avatar Jan 15 '22 11:01 alagoutte

@annakhm any news about this change ?

alagoutte avatar Feb 15 '22 08:02 alagoutte

Any news ?

alagoutte avatar May 12 '22 04:05 alagoutte

Hi @alagoutte, sorry for delayed response. There a more changes that need to be made for generation scripts, for example change NewDefault<!RESOURCE!>sClient(connector) to New<!RESOURCE!>sClient(connector) Also, I think boolFalse change is not global for every client. I think the best way to adjust generation scripts to the latest SDK, and test those adjustments, would be to create a new resource with the script.

annakhm avatar May 16 '22 17:05 annakhm

Hi @alagoutte, sorry for delayed response. There a more changes that need to be made for generation scripts, for example change NewDefault<!RESOURCE!>sClient(connector) to New<!RESOURCE!>sClient(connector) Also, I think boolFalse change is not global for every client. I think the best way to adjust generation scripts to the latest SDK, and test those adjustments, would be to create a new resource with the script.

Ok I will update when create a new ressource !

alagoutte avatar May 18 '22 04:05 alagoutte

This pull request for the provider is rather stale - should it move forward, be closed, or marked as draft?

Ryan Johnson Senior Staff Solutions Architect | Product Engineering @ VMware, Inc.

tenthirtyam avatar Oct 13 '22 04:10 tenthirtyam