singleton
singleton copied to clipboard
vmware
Use sample offline resource bundle zip in sample app
Shouldn't expose internal URL outside.
I checked and the artifactory (https://build-artifactory.eng.vmware.com/vip-gradle-local/) is an open URL ( I can access without authentication). It looks like it is not internal only?
If this is meant to be internal, @nannany00 , could you publish the artifact to external artifactory and I will change the URL in the sample app? Otherwise, @Xiaochao8 , please approve the PR.
Shouldn't expose internal URL outside.
I checked and the artifactory (https://build-artifactory.eng.vmware.com/vip-gradle-local/) is an open URL ( I can access without authentication). It looks like it is not internal only?
If this is meant to be internal, @nannany00 , could you publish the artifact to external artifactory and I will change the URL in the sample app? Otherwise, @Xiaochao8 , please approve the PR.
I can't visit it without VPN. Please double check? ping build-artifactory.eng.vmware.com Ping request could not find host build-artifactory.eng.vmware.com. Please check the name and try again.
Shouldn't expose internal URL outside.
I checked and the artifactory (https://build-artifactory.eng.vmware.com/vip-gradle-local/) is an open URL ( I can access without authentication). It looks like it is not internal only?
If this is meant to be internal, @nannany00 , could you publish the artifact to external artifactory and I will change the URL in the sample app? Otherwise, @Xiaochao8 , please approve the PR.
@jessiejuachon, this is an internal artifactory url. Actually, we don't have a public artifactory for open-source now.
Shouldn't expose internal URL outside.
I checked and the artifactory (https://build-artifactory.eng.vmware.com/vip-gradle-local/) is an open URL ( I can access without authentication). It looks like it is not internal only? If this is meant to be internal, @nannany00 , could you publish the artifact to external artifactory and I will change the URL in the sample app? Otherwise, @Xiaochao8 , please approve the PR.
@jessiejuachon, this is an internal artifactory url. Actually, we don't have a public artifactory for open-source now.
We publish to the central maven repo https://repo1.maven.org/maven2/com/vmware/singleton/ , right? Please publish it there, then I will update the repo URL in this PR. Thanks!
We publish to the central maven repo https://repo1.maven.org/maven2/com/vmware/singleton/ , right? Please publish it there, then I will update the repo URL in this PR. Thanks! @junw-33455432 is doing investigations whether we can publish the bundle zip into this repo. @junw-33455432, please add your feedback here. thanks.
After some investigation, we can push the bundle zip to maven repo, please provide the suggested folder structure of the root folder and the files to initialize the repo.
