open-iscsi systemd services broken

[szechyjs]

Describe the bug

iscsid.service fails load with the following error: /usr/lib/systemd/system/iscsid.service:13: Neither a valid executable name nor an absolute path: SBINDIR@/iscsid

It seems that https://github.com/open-iscsi/open-iscsi/pull/279 changed it to use @SBINDIR@, however for whatever reason the sed replace is not working during install.

Also, iscsid now depends on iscsi-init however this unit file is not being installed.

Reproduction steps

1. tdnf install open-iscsi
2. systemctl enable iscsid
3. systemctl start iscsid ...

Expected behavior

The service should run

Additional context

No response

[dcasota]

This still is an issue in Ph 5.0. Luckily make build of latest open-iscsi source seems to work flawlessly.

example:

tdnf update -y
tdnf install -y git build-essential

git clone https://<user>:<token>github.com/open-iscsi/open-iscsi
cd ./open-iscsi
tdnf install -y kmod-devel openssl-devel util-linux-devel open-isns-devel systemd-devel
make
make install

systemctl enable iscsid
systemctl start iscsid

# reminder to cleanup all temporary packages installed before if not needed anymore
tdnf remove -y systemd-devel open-isns-devel util-linux-devel openssl-devel kmod-devel build-essential git