open-vm-tools icon indicating copy to clipboard operation
open-vm-tools copied to clipboard

Published 20 hours ago • verified publisher icon vmware

Ensure that scriptFile is a file

Open yunzheng opened this issue 1 year ago • 11 comments

If the scripts directory contained a directory, for example pycache it would try to execute it. This ensures that we only execute files.

yunzheng avatar Sep 12 '23 16:09 yunzheng

@yunzheng, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

vmwclabot avatar Sep 12 '23 16:09 vmwclabot

@yunzheng, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed.

vmwclabot avatar Sep 12 '23 16:09 vmwclabot

@yunzheng, VMware has rejected your signed contributor license agreement. The merge can not proceed until the agreement has been resigned. Click here to resign the agreement. Reject reason:

Please provide more address detail - Minimum required is Country, State, Town/City.

vmwclabot avatar Sep 13 '23 07:09 vmwclabot

@yunzheng, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed.

vmwclabot avatar Sep 13 '23 07:09 vmwclabot

@yunzheng, VMware has approved your signed contributor license agreement.

vmwclabot avatar Sep 13 '23 19:09 vmwclabot

Do you happen to have any updates to this PR?

sever-sever avatar Feb 16 '24 13:02 sever-sever

The changes from this pull request has already been incorporated and will be in the next major release of open-vm-tools. Thanks for submitting the pull request.

vmwkruti1111 avatar Feb 16 '24 14:02 vmwkruti1111

No I don’t have any updates. PR should still be applicable.

@vmwkruti1111 good to know, was there a reason why the change was done outside this PR?

yunzheng avatar Feb 16 '24 14:02 yunzheng

Thanks again @yunzheng for your contribution, your patch has been accepted with additional modifications. The change has been made considering this PR only.

vmwkruti1111 avatar Feb 16 '24 14:02 vmwkruti1111

Alright, thanks. happy to see it being fixed. PR can be closed then :)

yunzheng avatar Feb 16 '24 15:02 yunzheng

@yunzheng Our source is maintained in a separate source repository; not directly on the github vmware/open-vm-tools repo. PRs are not directly merged into the github repo. When the actual change is provided on an open-vm-tools github branch, there will be a notification attached to this PR.

We will close this PR after the change shows up on "devel" branch and on the upcoming "stable-12.4.x" branch.

Thanks again for your contribution.

johnwvmw avatar Feb 16 '24 16:02 johnwvmw