load-balancer-and-ingress-services-for-kubernetes icon indicating copy to clipboard operation
load-balancer-and-ingress-services-for-kubernetes copied to clipboard

Image tag should be overridable

Open carpenterm opened this issue 3 years ago • 1 comments

In the AKO chart the image tag is hard coded:

image: "{{ .Values.image.repository }}:{{ .Chart.AppVersion }}"

We rebuild all of our open source images in our own repository and apply a build date suffix. We can't use the chart as it is without modifying it.

Standard practice is to allow the image tag to be overridden and have the image tag supplied in the default values.yaml file. Like this:

image: "{{ .Values.image.repository }}:{{ .Values.image.tag }}"

carpenterm avatar Jun 22 '21 16:06 carpenterm

Implementing the vmware bitnami common library & standards would also resolve this request:

dependencies:
  - name: common
    repository: oci://registry-1.docker.io/bitnamicharts
    tags:
      - bitnami-common
    version: 2.x.x

Established patterns to then follow would be: image

and image

lknite avatar Jan 24 '24 19:01 lknite