hillview icon indicating copy to clipboard operation
hillview copied to clipboard

Upload script does not update files

Open lalithsuresh opened this issue 6 years ago • 11 comments

Running: ./upload-data.py config-onecloud.py -d -s schema

The command runs and says it's doing rsync, but it doesn't update the schema file on the servers.

lalithsuresh avatar Jul 24 '18 01:07 lalithsuresh

https://github.com/vmware/hillview/pull/466

SivaAccionLabs avatar Oct 14 '18 18:10 SivaAccionLabs

@mbudiu-vmw Can close this issue.

SivaAccionLabs avatar Oct 17 '18 04:10 SivaAccionLabs

I think you have enough permissions to close issues as well, so feel free to do it when you think it should be done.

mihaibudiu avatar Oct 17 '18 05:10 mihaibudiu

@mbudiu-vmw Didn't close the fixed issues as I do not have the privilege to add the label as "fixed".

SivaAccionLabs avatar Oct 17 '18 05:10 SivaAccionLabs

Could you please grant the permission to add the label.

SivaAccionLabs avatar Oct 17 '18 05:10 SivaAccionLabs

Will look into this tomorrow. But you can close without the label too.

mihaibudiu avatar Oct 17 '18 05:10 mihaibudiu

I usually put the label while the pr is under review.

mihaibudiu avatar Oct 17 '18 05:10 mihaibudiu

Sure Mihai.

SivaAccionLabs avatar Oct 17 '18 05:10 SivaAccionLabs

@mbudiu-vmw I have the privilege to close the issues, which are opened by me only not by others.

SivaAccionLabs avatar Oct 17 '18 05:10 SivaAccionLabs

I am not sure that the issue is fixed. The line that was copying the files was removed by mistake only recently. I believe that the issue is about rsync not always updating files that have changed.

mihaibudiu avatar Oct 17 '18 15:10 mihaibudiu

@SivaMaplelabs : I am actually not the owner of this repository, this is owned and administered by VMware IT. So I don't see how I can grant you additional right. For now let's continue to operate in this way, I don't think this will preclude you from contributing.

mihaibudiu avatar Oct 17 '18 16:10 mihaibudiu