goipmi icon indicating copy to clipboard operation
goipmi copied to clipboard

Dcmi management controller string support

Open connorgorman opened this issue 9 years ago • 7 comments

connorgorman avatar May 24 '16 22:05 connorgorman

Thanks @connorgorman , looks good to me. I'd prefer to avoid using git submodules however, do you mind removing that part? Would rather vendor using a tool such as gvt, or even remove the dependency on testify and just using testing from stdlib.

dougm avatar May 25 '16 20:05 dougm

We should have also seen an automated CLA request from @vmwclabot

dougm avatar May 25 '16 20:05 dougm

@dougm Sounds good. I'll remove the dependency altogether

connorgorman avatar May 25 '16 20:05 connorgorman

@dougm the CLA bot is not turned on for this project. I'll get it enabled today. Drop me an e-mail if there are any other projects you want it enabled on. Thanks!

travisfinch avatar May 25 '16 20:05 travisfinch

@connorgorman, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

vmwclabot avatar May 26 '16 02:05 vmwclabot

@dougm I reverted the dependency management piece, but did leave the strechr dependency as I didn't see an easy way to decouple the project from it. Also, the CLA has been sent to Medallia's legal team. Thanks

connorgorman avatar Jun 06 '16 17:06 connorgorman

@connorgorman, your company's legal contact did not review your signed contributor license agreement within the 14 day limit. The merge can not proceed. Click here to resign the agreement.

vmwclabot avatar Jun 20 '16 18:06 vmwclabot