go-ipfix icon indicating copy to clipboard operation
go-ipfix copied to clipboard

Don't stop upon packet decode errors

Open ivan4th opened this issue 3 years ago • 3 comments

We shouldn't stop the collector if it happens to receive a dataset packet before the corresponding template

ivan4th avatar Feb 22 '22 05:02 ivan4th

@ivan4th, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

vmwclabot avatar Feb 22 '22 05:02 vmwclabot

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 73.51%. Comparing base (63fca07) to head (2d390c0). Report is 49 commits behind head on main.

Files Patch % Lines
pkg/collector/udp.go 0.00% 1 Missing :warning:
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #277      +/-   ##
==========================================
- Coverage   73.58%   73.51%   -0.08%     
==========================================
  Files          18       18              
  Lines        2760     2760              
==========================================
- Hits         2031     2029       -2     
- Misses        563      564       +1     
- Partials      166      167       +1     
Flag Coverage Δ
integration-tests 51.48% <0.00%> (-0.17%) :arrow_down:
unit-tests 72.21% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/collector/udp.go 68.13% <0.00%> (ø)

... and 1 file with indirect coverage changes

codecov[bot] avatar Feb 23 '22 18:02 codecov[bot]

@ivan4th, your company's legal contact did not review your signed contributor license agreement within the 14 day limit. The merge can not proceed. Click here to resign the agreement.

vmwclabot avatar Mar 08 '22 05:03 vmwclabot

Superseded by https://github.com/vmware/go-ipfix/pull/352

antoninbas avatar Aug 21 '24 19:08 antoninbas