differential-datalog icon indicating copy to clipboard operation
differential-datalog copied to clipboard

Reduce dependency bloat

Open Kixiron opened this issue 3 years ago • 4 comments

  • Started trying to remove num from the dependency tree
  • Removed some of the "default dependencies" from generated crates, this should allow better compilation scheduling since crates don't have to wait on unnecessary dependencies
  • Discovered that some files are in CLRF form, this will be fixed in a later PR
  • Removed dependencies on fnv and twox-hash and replaced with a single dependence on xxhash-rust, it has zero dependencies and is very light
  • Removed old dependence on time for all generated crates, this reduced the dependency tree a good bit
  • Minor refactors to some massive match statements
  • Added some documentation to the DDVal/DDValue innards

Kixiron avatar Nov 12 '21 17:11 Kixiron

@Kixiron, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

vmwclabot avatar Nov 12 '21 17:11 vmwclabot

Some of these files show every line as different. Is this due to CR/LF? This makes it hard to review.

mihaibudiu avatar Nov 12 '21 17:11 mihaibudiu

Yes, those are files that were changed from CLRF to LF, I'll make a PR that bites the bullet and standardizes things after this. In the diff view select the Hide Whitespace option to ignore the line ending changes

image

Kixiron avatar Nov 12 '21 17:11 Kixiron

@Kixiron, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

vmwclabot avatar Nov 15 '21 19:11 vmwclabot