container-service-extension icon indicating copy to clipboard operation
container-service-extension copied to clipboard

Published 20 hours ago • verified publisher icon vmware

Add missing requirement for click

Open gmcelhoe opened this issue 5 years ago • 2 comments

The code requires click>=7.0 as a requirement

Discovered this while installing the scripts in an empty python container.

Signed-off-by: Glenn McElhoe [email protected]

This change is Reviewable

gmcelhoe avatar Feb 08 '19 15:02 gmcelhoe

The click requirement should have been met by vcd-cli. (click >= 6.7) CSE has a requirement on vcd-cli.

Can you please elaborate, what exactly in CSE depends on click >= 7.0?

rocknes avatar Feb 08 '19 18:02 rocknes

I count at least 7 different python files in CSE that import click. https://github.com/vmware/container-service-extension/search?q=import+click&unscoped_q=import+click

It is good practice not to rely on transitive dependencies; what if vcd-cli changes?

gmcelhoe avatar Feb 11 '19 16:02 gmcelhoe