cluster-api-provider-cloud-director icon indicating copy to clipboard operation
cluster-api-provider-cloud-director copied to clipboard

patch to overload LB port on reconciliation loop

Open Maellooou opened this issue 1 year ago • 3 comments

Description

Please provide a brief description of the changes proposed in this Pull Request

  • The variable controlPlanePort is reset at default value at each loop. Use the vcdCluster.Spec.ControlPlaneEndpoint.Port value if it is defined

Checklist

  • [X] tested locally
  • [ ] updated any relevant dependencies
  • [ ] updated any relevant documentation or examples

API Changes

Are there API changes?

  • [ ] Yes
  • [X] No

If yes, please fill in the below

  1. Updated conversions?
    • [ ] Yes
    • [ ] No
    • [ ] N/A
  2. Updated CRDs?
    • [ ] Yes
    • [ ] No
    • [ ] N/A
  3. Updated infrastructure-components.yaml?
    • [ ] Yes
    • [ ] No
    • [ ] N/A
  4. Updated ./examples/capi-quickstart.yaml?
    • [ ] Yes
    • [ ] No
    • [ ] N/A
  5. Updated necessary files under ./infrastructure-vcd/v1.0.0/?
    • [ ] Yes
    • [ ] No
    • [ ] N/A

Issue

If applicable, please reference the relevant issue

Fixes # Fixe bug #583


This change is Reviewable

Maellooou avatar Jan 18 '24 13:01 Maellooou

@Maellooou, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

vmwclabot avatar Jan 18 '24 13:01 vmwclabot

@Maellooou, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed.

vmwclabot avatar Jan 18 '24 13:01 vmwclabot

@Maellooou, VMware has approved your signed contributor license agreement.

vmwclabot avatar Jan 18 '24 16:01 vmwclabot