Add `node.kubernetes.io/instance-type` label to nodes

[viveksyngh]

Is your feature request related to a problem? Please describe.

We would like to add node.kubernetes.io/instance-type labels to nodes provisioned using CAPVCD similar to other cloud provider node.kubernetes.io/instance-type.

https://kubernetes.io/docs/reference/labels-annotations-taints/#nodekubernetesioinstance-type

Describe the solution you'd like

We can add the sizing policy of VCDMachine object as instanceType of the nodes. These labels can be added as metadata in init or join configuration of the nodes.

Describe alternatives you've considered

No response

Additional context

No response

[dlipovetsky]

As far as I understand, the instance-type label is set by kubelet, based on information it retrieves using the InstanceType method of the Cloud Provider Interface (CPI).

For example, the vSphere Cloud Provider implements this method.

I think this issue should be moved to the VCD Cloud Provider, https://github.com/vmware/cloud-provider-for-cloud-director

[Anirudh9794]

Hi @viveksyngh can you please open the issue in CPI project as the changes need to be done in https://github.com/vmware/cloud-provider-for-cloud-director repository ?

Thank you!

[viveksyngh]

Sure