build-tools-for-vmware-aria icon indicating copy to clipboard operation
build-tools-for-vmware-aria copied to clipboard
verified publisher icon vmware

`artifact-manager` needs to be better structured

Open Michaelpalacce opened this issue 1 year ago • 3 comments

Description

The structure of artifact-manager needs to be refactored to be better structured. Currently there is almost no structure and classes are added to random places.

Examples

store folder has filters, I'd assume that different stores should be put here Pasted image 20240704184928

Store classes not under store folder Pasted image 20240704184959

Special structure for vRLI under rest/client, but no other clients present image

Misplaced models image

Proposal

image
  1. Ignore the fact that it says artifact-new this is just a placeholder, the same artifact folder should be used.
  2. Each different archetype is put in a separate folder
  3. common folder contains any common components that can be used by the other archetypes
  4. Inside the archetype folders, if the API is versioned, then we need to have a clear distinction for that too... this is only valid for major API changes, example would be vRLI v1 and v2 apis.
    • Example:
    • image

Michaelpalacce avatar Jul 11 '24 07:07 Michaelpalacce

@akantchev this will not be a breaking change, correct? If so do we need to have the 3.0.0 milestone?

Michaelpalacce avatar Jul 15 '24 08:07 Michaelpalacce

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Aug 15 '24 01:08 github-actions[bot]

Partially implemented in milestone 3.x.x, will be finished in 4.x.x

VenelinBakalov avatar Jan 30 '25 13:01 VenelinBakalov

Related PRs:

  • https://github.com/vmware/build-tools-for-vmware-aria/pull/581
  • https://github.com/vmware/build-tools-for-vmware-aria/pull/593
  • https://github.com/vmware/build-tools-for-vmware-aria/pull/710
  • https://github.com/vmware/build-tools-for-vmware-aria/pull/829

VenelinBakalov avatar May 29 '25 08:05 VenelinBakalov

https://github.com/vmware/build-tools-for-vmware-aria/blob/main/common/artifact-manager/src/main/java/com/vmware/pscoe/iac/artifact/IMPORTANT.md

VenelinBakalov avatar Aug 06 '25 09:08 VenelinBakalov

Good job @VenelinBakalov 😁 this has been a hell of a task, finally done

Michaelpalacce avatar Aug 19 '25 08:08 Michaelpalacce

@Michaelpalacce it was fun, especially the linter fixes :D as usual, thanks for suggesting this restructuring and proposing the current state - the new organization is way better and much easier to work with

VenelinBakalov avatar Aug 19 '25 09:08 VenelinBakalov