vm-operator
vm-operator copied to clipboard
vmware-tanzu
✨ virtualmachinesetresourcepolicy: allow mutability of .spec.clusterModuleGroups
What does this PR do, and why is it needed?
- Allows modification of VirtualMachinesetResourcePolicy.spec.clusterModuleGroups
- Adjust the reconciler for VirtualMachinesetResourcePolicy to create or delete ClusterModuleGroups on changes to
.spec.clusterModuleGroups.
Which issue(s) is/are addressed by this PR? (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Are there any special notes for your reviewer:
I implemented some changes for CAPV and did take a quick look into this for vm-operator and seemed not to be too hard so I went ahead and implemented this feature.
Please add a release note if necessary:
Allow mutability of ClusterModuleGroups in VirtualMachinesetResourcePolicy
~~It looks like you did not include the change to the actual validation webhook?~~
Nevermind, I am an idiot.
@chrischdi I think you will need to also update the webhook's unit/integ tests.
Thanks for the prompt responses, I hope this does not make too much noise to you folks. I had it around and thought it might be worth to not double the work / help you out :-) .
I will take a look at the tests and the comments next week.
Please don't hestitate let me know if you currently have no time for this and want to follow up yourself on it. I'm also okay to help bring this over the finish line :-)
| Package | Line Rate | Health |
|---|---|---|
| github.com/vmware-tanzu/vm-operator/controllers/contentlibrary/clustercontentlibraryitem | 100% | ✔ |
| github.com/vmware-tanzu/vm-operator/controllers/contentlibrary/contentlibraryitem | 100% | ✔ |
| github.com/vmware-tanzu/vm-operator/controllers/contentlibrary/utils | 89% | ➖ |
| github.com/vmware-tanzu/vm-operator/controllers/infra/capability/configmap | 92% | ✔ |
| github.com/vmware-tanzu/vm-operator/controllers/infra/capability/crd | 100% | ✔ |
| github.com/vmware-tanzu/vm-operator/controllers/infra/configmap | 74% | ❌ |
| github.com/vmware-tanzu/vm-operator/controllers/infra/node | 77% | ❌ |
| github.com/vmware-tanzu/vm-operator/controllers/infra/secret | 76% | ❌ |
| github.com/vmware-tanzu/vm-operator/controllers/infra/validatingwebhookconfiguration | 85% | ➖ |
| github.com/vmware-tanzu/vm-operator/controllers/infra/zone | 73% | ❌ |
| github.com/vmware-tanzu/vm-operator/controllers/storageclass | 95% | ✔ |
| github.com/vmware-tanzu/vm-operator/controllers/storagepolicyquota | 97% | ✔ |
| github.com/vmware-tanzu/vm-operator/controllers/util/encoding | 73% | ❌ |
| github.com/vmware-tanzu/vm-operator/controllers/virtualmachine/storagepolicyusage | 98% | ✔ |
| github.com/vmware-tanzu/vm-operator/controllers/virtualmachine/virtualmachine | 70% | ❌ |
| github.com/vmware-tanzu/vm-operator/controllers/virtualmachine/volume | 86% | ➖ |
| github.com/vmware-tanzu/vm-operator/controllers/virtualmachineclass | 75% | ❌ |
| github.com/vmware-tanzu/vm-operator/controllers/virtualmachineimagecache | 89% | ✔ |
| github.com/vmware-tanzu/vm-operator/controllers/virtualmachinepublishrequest | 81% | ➖ |
| github.com/vmware-tanzu/vm-operator/controllers/virtualmachinereplicaset | 67% | ❌ |
| github.com/vmware-tanzu/vm-operator/controllers/virtualmachineservice | 83% | ➖ |
| github.com/vmware-tanzu/vm-operator/controllers/virtualmachineservice/providers | 92% | ✔ |
| github.com/vmware-tanzu/vm-operator/controllers/virtualmachinesetresourcepolicy | 82% | ➖ |
| github.com/vmware-tanzu/vm-operator/controllers/virtualmachinewebconsolerequest | 72% | ❌ |
| github.com/vmware-tanzu/vm-operator/controllers/virtualmachinewebconsolerequest/v1alpha1 | 72% | ❌ |
| github.com/vmware-tanzu/vm-operator/controllers/virtualmachinewebconsolerequest/v1alpha1/conditions | 88% | ➖ |
| github.com/vmware-tanzu/vm-operator/controllers/virtualmachinewebconsolerequest/v1alpha1/patch | 78% | ❌ |
| github.com/vmware-tanzu/vm-operator/pkg/bitmask | 100% | ✔ |
| github.com/vmware-tanzu/vm-operator/pkg/builder | 95% | ✔ |
| github.com/vmware-tanzu/vm-operator/pkg/conditions | 90% | ✔ |
| github.com/vmware-tanzu/vm-operator/pkg/config | 100% | ✔ |
| github.com/vmware-tanzu/vm-operator/pkg/config/capabilities | 100% | ✔ |
| github.com/vmware-tanzu/vm-operator/pkg/config/env | 100% | ✔ |
| github.com/vmware-tanzu/vm-operator/pkg/context/generic | 100% | ✔ |
| github.com/vmware-tanzu/vm-operator/pkg/context/operation | 100% | ✔ |
| github.com/vmware-tanzu/vm-operator/pkg/errors | 100% | ✔ |
| github.com/vmware-tanzu/vm-operator/pkg/exit | 100% | ✔ |
| github.com/vmware-tanzu/vm-operator/pkg/mem | 100% | ✔ |
| github.com/vmware-tanzu/vm-operator/pkg/patch | 78% | ❌ |
| github.com/vmware-tanzu/vm-operator/pkg/prober | 91% | ✔ |
| github.com/vmware-tanzu/vm-operator/pkg/prober/probe | 90% | ✔ |
| github.com/vmware-tanzu/vm-operator/pkg/prober/worker | 77% | ❌ |
| github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere | 76% | ❌ |
| github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/client | 80% | ➖ |
| github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/clustermodules | 73% | ❌ |
| github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/config | 88% | ➖ |
| github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/contentlibrary | 72% | ❌ |
| github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/credentials | 100% | ✔ |
| github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/network | 80% | ➖ |
| github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/placement | 80% | ➖ |
| github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/session | 71% | ❌ |
| github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/storage | 44% | ❌ |
| github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/sysprep | 100% | ✔ |
| github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/vcenter | 86% | ➖ |
| github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/virtualmachine | 85% | ➖ |
| github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/vmlifecycle | 64% | ❌ |
| github.com/vmware-tanzu/vm-operator/pkg/record | 87% | ➖ |
| github.com/vmware-tanzu/vm-operator/pkg/topology | 91% | ✔ |
| github.com/vmware-tanzu/vm-operator/pkg/util | 88% | ➖ |
| github.com/vmware-tanzu/vm-operator/pkg/util/cloudinit | 89% | ✔ |
| github.com/vmware-tanzu/vm-operator/pkg/util/cloudinit/validate | 91% | ✔ |
| github.com/vmware-tanzu/vm-operator/pkg/util/image | 100% | ✔ |
| github.com/vmware-tanzu/vm-operator/pkg/util/kube | 89% | ➖ |
| github.com/vmware-tanzu/vm-operator/pkg/util/kube/cource | 100% | ✔ |
| github.com/vmware-tanzu/vm-operator/pkg/util/kube/internal | 100% | ✔ |
| github.com/vmware-tanzu/vm-operator/pkg/util/kube/proxyaddr | 73% | ❌ |
| github.com/vmware-tanzu/vm-operator/pkg/util/kube/spq | 100% | ✔ |
| github.com/vmware-tanzu/vm-operator/pkg/util/netplan | 100% | ✔ |
| github.com/vmware-tanzu/vm-operator/pkg/util/ovfcache | 75% | ❌ |
| github.com/vmware-tanzu/vm-operator/pkg/util/ovfcache/internal | 100% | ✔ |
| github.com/vmware-tanzu/vm-operator/pkg/util/paused | 100% | ✔ |
| github.com/vmware-tanzu/vm-operator/pkg/util/ptr | 100% | ✔ |
| github.com/vmware-tanzu/vm-operator/pkg/util/resize | 99% | ✔ |
| github.com/vmware-tanzu/vm-operator/pkg/util/vmopv1 | 81% | ➖ |
| github.com/vmware-tanzu/vm-operator/pkg/util/vsphere/client | 64% | ❌ |
| github.com/vmware-tanzu/vm-operator/pkg/util/vsphere/library | 100% | ✔ |
| github.com/vmware-tanzu/vm-operator/pkg/util/vsphere/vm | 79% | ❌ |
| github.com/vmware-tanzu/vm-operator/pkg/util/vsphere/watcher | 85% | ➖ |
| github.com/vmware-tanzu/vm-operator/pkg/vmconfig | 95% | ✔ |
| github.com/vmware-tanzu/vm-operator/pkg/vmconfig/crypto | 91% | ✔ |
| github.com/vmware-tanzu/vm-operator/pkg/webconsolevalidation | 100% | ✔ |
| github.com/vmware-tanzu/vm-operator/services/vm-watcher | 94% | ✔ |
| github.com/vmware-tanzu/vm-operator/webhooks/common | 100% | ✔ |
| github.com/vmware-tanzu/vm-operator/webhooks/persistentvolumeclaim/validation | 95% | ✔ |
| github.com/vmware-tanzu/vm-operator/webhooks/unifiedstoragequota/validation | 89% | ✔ |
| github.com/vmware-tanzu/vm-operator/webhooks/virtualmachine/mutation | 87% | ➖ |
| github.com/vmware-tanzu/vm-operator/webhooks/virtualmachine/validation | 95% | ✔ |
| github.com/vmware-tanzu/vm-operator/webhooks/virtualmachineclass/mutation | 62% | ❌ |
| github.com/vmware-tanzu/vm-operator/webhooks/virtualmachineclass/validation | 89% | ➖ |
| github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinepublishrequest/validation | 92% | ✔ |
| github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinereplicaset/validation | 90% | ✔ |
| github.com/vmware-tanzu/vm-operator/webhooks/virtualmachineservice/mutation | 67% | ❌ |
| github.com/vmware-tanzu/vm-operator/webhooks/virtualmachineservice/validation | 92% | ✔ |
| github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinesetresourcepolicy/validation | 89% | ➖ |
| github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinewebconsolerequest/v1alpha1/validation | 92% | ✔ |
| github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinewebconsolerequest/validation | 92% | ✔ |
| Summary | 83% (11505 / 13932) | ➖ |
Minimum allowed line rate is 79%
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
/close
Will not have bandwidth to come back to this (if this even makes sense)