vm-operator
vm-operator copied to clipboard
vmware-tanzu
🌱 Make VM Spec ChangeBlockTracking nillable
What does this PR do, and why is it needed?
When this field is unset, we should fallback to the VM Class ConfigSpec value if set.
Update logic in UpdateConfigSpecChangeBlockTracking() to prefer the VM Spec value if set.
Which issue(s) is/are addressed by this PR? (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Are there any special notes for your reviewer:
Preferring fields set in the VM Spec is the resize behavior that we want for the upcoming resize work. This lets the DevOps user override values set in the class.
Please add a release note if necessary:
Make VirtualMachine spec.advanced.changeBlockTracking nillable
| Package | Line Rate | Health |
|---|---|---|
| github.com/vmware-tanzu/vm-operator/api/v1alpha1 | 42% | ❌ |
| github.com/vmware-tanzu/vm-operator/api/v1alpha2 | 9% | ❌ |
| github.com/vmware-tanzu/vm-operator/controllers/contentlibrary/clustercontentlibraryitem | 82% | ✔ |
| github.com/vmware-tanzu/vm-operator/controllers/contentlibrary/contentlibraryitem | 86% | ✔ |
| github.com/vmware-tanzu/vm-operator/controllers/contentlibrary/utils | 32% | ❌ |
| github.com/vmware-tanzu/vm-operator/controllers/infra/configmap | 71% | ➖ |
| github.com/vmware-tanzu/vm-operator/controllers/infra/node | 77% | ➖ |
| github.com/vmware-tanzu/vm-operator/controllers/infra/secret | 77% | ➖ |
| github.com/vmware-tanzu/vm-operator/controllers/util/encoding | 73% | ➖ |
| github.com/vmware-tanzu/vm-operator/controllers/virtualmachine | 69% | ➖ |
| github.com/vmware-tanzu/vm-operator/controllers/virtualmachineclass | 21% | ❌ |
| github.com/vmware-tanzu/vm-operator/controllers/virtualmachinepublishrequest | 81% | ✔ |
| github.com/vmware-tanzu/vm-operator/controllers/virtualmachineservice | 82% | ✔ |
| github.com/vmware-tanzu/vm-operator/controllers/virtualmachineservice/providers | 92% | ✔ |
| github.com/vmware-tanzu/vm-operator/controllers/virtualmachinesetresourcepolicy | 81% | ✔ |
| github.com/vmware-tanzu/vm-operator/controllers/virtualmachinewebconsolerequest/v1alpha1 | 72% | ➖ |
| github.com/vmware-tanzu/vm-operator/controllers/virtualmachinewebconsolerequest/v1alpha1/conditions | 88% | ✔ |
| github.com/vmware-tanzu/vm-operator/controllers/virtualmachinewebconsolerequest/v1alpha1/patch | 78% | ➖ |
| github.com/vmware-tanzu/vm-operator/controllers/virtualmachinewebconsolerequest/v1alpha2 | 73% | ➖ |
| github.com/vmware-tanzu/vm-operator/controllers/volume | 86% | ✔ |
| github.com/vmware-tanzu/vm-operator/pkg/conditions | 88% | ✔ |
| github.com/vmware-tanzu/vm-operator/pkg/config | 100% | ✔ |
| github.com/vmware-tanzu/vm-operator/pkg/config/env | 100% | ✔ |
| github.com/vmware-tanzu/vm-operator/pkg/patch | 16% | ❌ |
| github.com/vmware-tanzu/vm-operator/pkg/prober | 54% | ❌ |
| github.com/vmware-tanzu/vm-operator/pkg/prober/probe | 91% | ✔ |
| github.com/vmware-tanzu/vm-operator/pkg/prober/worker | 77% | ➖ |
| github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere | 71% | ➖ |
| github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/client | 57% | ❌ |
| github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/clustermodules | 71% | ➖ |
| github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/config | 72% | ➖ |
| github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/contentlibrary | 72% | ➖ |
| github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/credentials | 100% | ✔ |
| github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/network | 80% | ➖ |
| github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/placement | 77% | ➖ |
| github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/session | 34% | ❌ |
| github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/sysprep | 100% | ✔ |
| github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/vcenter | 83% | ✔ |
| github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/virtualmachine | 75% | ➖ |
| github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/vmlifecycle | 66% | ➖ |
| github.com/vmware-tanzu/vm-operator/pkg/record | 78% | ➖ |
| github.com/vmware-tanzu/vm-operator/pkg/topology | 55% | ❌ |
| github.com/vmware-tanzu/vm-operator/pkg/util | 78% | ➖ |
| github.com/vmware-tanzu/vm-operator/pkg/util/cloudinit | 89% | ✔ |
| github.com/vmware-tanzu/vm-operator/pkg/util/cloudinit/validate | 91% | ✔ |
| github.com/vmware-tanzu/vm-operator/pkg/util/image | 100% | ✔ |
| github.com/vmware-tanzu/vm-operator/pkg/util/kube | 90% | ✔ |
| github.com/vmware-tanzu/vm-operator/pkg/util/vmopv1 | 93% | ✔ |
| github.com/vmware-tanzu/vm-operator/pkg/util/vsphere/client | 68% | ➖ |
| github.com/vmware-tanzu/vm-operator/pkg/util/vsphere/vm | 78% | ➖ |
| github.com/vmware-tanzu/vm-operator/pkg/webconsolevalidation | 51% | ❌ |
| github.com/vmware-tanzu/vm-operator/webhooks/common | 100% | ✔ |
| github.com/vmware-tanzu/vm-operator/webhooks/persistentvolumeclaim/validation | 95% | ✔ |
| github.com/vmware-tanzu/vm-operator/webhooks/virtualmachine/mutation | 87% | ✔ |
| github.com/vmware-tanzu/vm-operator/webhooks/virtualmachine/validation | 95% | ✔ |
| github.com/vmware-tanzu/vm-operator/webhooks/virtualmachineclass/mutation | 62% | ➖ |
| github.com/vmware-tanzu/vm-operator/webhooks/virtualmachineclass/validation | 89% | ✔ |
| github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinepublishrequest/validation | 92% | ✔ |
| github.com/vmware-tanzu/vm-operator/webhooks/virtualmachineservice/mutation | 67% | ➖ |
| github.com/vmware-tanzu/vm-operator/webhooks/virtualmachineservice/validation | 92% | ✔ |
| github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinesetresourcepolicy/validation | 89% | ✔ |
| github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinewebconsolerequest/v1alpha1/validation | 92% | ✔ |
| github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinewebconsolerequest/v1alpha2/validation | 92% | ✔ |
| Summary | 56% (8141 / 14519) | ❌ |
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}