🌱 Add VM predicate to Volume controller

[bryanv]

What does this PR do, and why is it needed?

The Volume controller only needs to reconcile the VM when certain fields on the VM changes. Add a predicate so that we do not do needless reconciles since these reconciles can be expensive.

Which issue(s) is/are addressed by this PR? (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

Fixes #

Are there any special notes for your reviewer:

This is just WIP MR. IDK if I'll ever merge this since it does make things a little subtle or brittle to later changes.

Please add a release note if necessary:

NONE

[github-actions[bot]]

Package	Line Rate	Health
github.com/vmware-tanzu/vm-operator/api/v1alpha1	42%	❌
github.com/vmware-tanzu/vm-operator/controllers/contentlibrary/v1alpha2/clustercontentlibraryitem	81%	✔
github.com/vmware-tanzu/vm-operator/controllers/contentlibrary/v1alpha2/contentlibraryitem	85%	✔
github.com/vmware-tanzu/vm-operator/controllers/contentlibrary/v1alpha2/utils	32%	❌
github.com/vmware-tanzu/vm-operator/controllers/infra/configmap	71%	➖
github.com/vmware-tanzu/vm-operator/controllers/infra/node	77%	➖
github.com/vmware-tanzu/vm-operator/controllers/infra/secret	77%	➖
github.com/vmware-tanzu/vm-operator/controllers/util/encoding	73%	➖
github.com/vmware-tanzu/vm-operator/controllers/virtualmachine/v1alpha2	70%	➖
github.com/vmware-tanzu/vm-operator/controllers/virtualmachineclass/v1alpha2	21%	❌
github.com/vmware-tanzu/vm-operator/controllers/virtualmachinepublishrequest/v1alpha2	81%	✔
github.com/vmware-tanzu/vm-operator/controllers/virtualmachineservice/v1alpha2	83%	✔
github.com/vmware-tanzu/vm-operator/controllers/virtualmachineservice/v1alpha2/providers	89%	✔
github.com/vmware-tanzu/vm-operator/controllers/virtualmachineservice/v1alpha2/providers/simplelb	66%	➖
github.com/vmware-tanzu/vm-operator/controllers/virtualmachinesetresourcepolicy/v1alpha2	81%	✔
github.com/vmware-tanzu/vm-operator/controllers/virtualmachinewebconsolerequest/v1alpha1	72%	➖
github.com/vmware-tanzu/vm-operator/controllers/virtualmachinewebconsolerequest/v1alpha1/conditions	88%	✔
github.com/vmware-tanzu/vm-operator/controllers/virtualmachinewebconsolerequest/v1alpha1/patch	78%	➖
github.com/vmware-tanzu/vm-operator/controllers/virtualmachinewebconsolerequest/v1alpha2	73%	➖
github.com/vmware-tanzu/vm-operator/controllers/volume/v1alpha2	86%	✔
github.com/vmware-tanzu/vm-operator/pkg/conditions	88%	✔
github.com/vmware-tanzu/vm-operator/pkg/config	100%	✔
github.com/vmware-tanzu/vm-operator/pkg/config/env	100%	✔
github.com/vmware-tanzu/vm-operator/pkg/patch	16%	❌
github.com/vmware-tanzu/vm-operator/pkg/prober	54%	❌
github.com/vmware-tanzu/vm-operator/pkg/prober/probe	90%	✔
github.com/vmware-tanzu/vm-operator/pkg/prober/worker	77%	➖
github.com/vmware-tanzu/vm-operator/pkg/record	78%	➖
github.com/vmware-tanzu/vm-operator/pkg/topology	55%	❌
github.com/vmware-tanzu/vm-operator/pkg/util	78%	➖
github.com/vmware-tanzu/vm-operator/pkg/util/cloudinit	89%	✔
github.com/vmware-tanzu/vm-operator/pkg/util/cloudinit/validate	91%	✔
github.com/vmware-tanzu/vm-operator/pkg/util/kube	90%	✔
github.com/vmware-tanzu/vm-operator/pkg/util/vsphere/client	68%	➖
github.com/vmware-tanzu/vm-operator/pkg/util/vsphere/vm	78%	➖
github.com/vmware-tanzu/vm-operator/pkg/vmprovider/providers/vsphere2	71%	➖
github.com/vmware-tanzu/vm-operator/pkg/vmprovider/providers/vsphere2/client	57%	❌
github.com/vmware-tanzu/vm-operator/pkg/vmprovider/providers/vsphere2/clustermodules	71%	➖
github.com/vmware-tanzu/vm-operator/pkg/vmprovider/providers/vsphere2/config	72%	➖
github.com/vmware-tanzu/vm-operator/pkg/vmprovider/providers/vsphere2/contentlibrary	72%	➖
github.com/vmware-tanzu/vm-operator/pkg/vmprovider/providers/vsphere2/credentials	100%	✔
github.com/vmware-tanzu/vm-operator/pkg/vmprovider/providers/vsphere2/network	78%	➖
github.com/vmware-tanzu/vm-operator/pkg/vmprovider/providers/vsphere2/placement	77%	➖
github.com/vmware-tanzu/vm-operator/pkg/vmprovider/providers/vsphere2/session	33%	❌
github.com/vmware-tanzu/vm-operator/pkg/vmprovider/providers/vsphere2/sysprep	100%	✔
github.com/vmware-tanzu/vm-operator/pkg/vmprovider/providers/vsphere2/vcenter	79%	➖
github.com/vmware-tanzu/vm-operator/pkg/vmprovider/providers/vsphere2/virtualmachine	77%	➖
github.com/vmware-tanzu/vm-operator/pkg/vmprovider/providers/vsphere2/vmlifecycle	61%	➖
github.com/vmware-tanzu/vm-operator/pkg/webconsolevalidation	51%	❌
github.com/vmware-tanzu/vm-operator/webhooks/common	100%	✔
github.com/vmware-tanzu/vm-operator/webhooks/persistentvolumeclaim/validation	95%	✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachine/v1alpha2/mutation	83%	✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachine/v1alpha2/validation	95%	✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachineclass/v1alpha2/mutation	62%	➖
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachineclass/v1alpha2/validation	89%	✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinepublishrequest/v1alpha2/validation	92%	✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachineservice/v1alpha2/mutation	67%	➖
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachineservice/v1alpha2/validation	91%	✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinesetresourcepolicy/v1alpha2/validation	89%	✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinewebconsolerequest/v1alpha1/validation	92%	✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinewebconsolerequest/v1alpha2/validation	92%	✔
Summary	67% (7650 / 11376)	➖

Minimum allowed line rate is 60%