Binary support for s390x

[pandurangkhandeparker]

Thank you for contributing to Velero!

Signed-off-by: Pandurang Alias Aradhya Khandeparker [email protected]

Please add a summary of your change

This PR aims to add s390x support to Velero binary.

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

• [x] Accepted the DCO. Commits without the DCO will delay acceptance.
• [x] Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
• [ ] Updated the corresponding documentation in site/content/docs/main.

[reasonerjt]

IMHO, given we don't have resources or bandwidth to verify on zLinux, shall we let this remain downstream?

[rposts]

@reasonerjt If access to s390x system to run tests is an issue then IBM now has a public program for requesting virtual machines for s390x. A member of the Velero team can put in a request via the following form. When approved and sign-up is complete resources can be set up and delegated as appropriate. https://www.ibm.com/community/z/open-source/virtual-machines-request/

Please let us know what is required for s390x binary verification.

It will be great for s390x to be part of several ecosystem that Velero already supports which includes ppc64le and arm as well.

[kaovilai]

Are we open to unsupported binary release (at your own risk)?

[rposts]

Are we open to unsupported binary release (at your own risk)?

I think we should try to maintain fidelity with other archs - at a minimum s390x binary should pass associated testcases .

[kaovilai]

at a minimum s390x binary should pass associated testcases

How do you propose velero obtain the infra to test this? Running in github actions emulated would be very slow.

[rposts]

at a minimum s390x binary should pass associated testcases

How do you propose velero obtain the infra to test this? Running in github actions emulated would be very slow. @kaovilai - pls see above "..A member of the Velero team can put in a request via the following form. When approved and sign-up is complete resources can be set up and delegated as appropriate. https://www.ibm.com/community/z/open-source/virtual-machines-request/ "

This is a real s390x VM which can be used to run the testcases.

[kaovilai]

If it can be added as a github actions runner maybe. That way is not another separate test pipeline.. only maintainers can add new hosted runners to the repo tho.

[kaovilai]

It's not just access, but lack of maintainers bandwidth to prioritize signing up for a new account and hooking it up to CI.

If you have a fork that produces binaries I think it'll be an easier pill to swallow for maintainers to link to your fork for an unofficial s390x binary.

Tho personally I think unverified binary is ok upstream.

[rposts]

@kaovilai Thanks for following up on this PR. For this iteration, is it possible to release artifacts similar to this ppc64le implementation? I am unable to determine ppc64le CI is running extensive tests.

[sseago]

@kaovilai Thanks for following up on this PR. For this iteration, is it possible to release artifacts similar to this ppc64le implementation? I am unable to determine ppc64le CI is running extensive tests.

Looks like that added build support for ppc64le but explicitly disabled publishing docker images. So I think this means the testing infra does not test on this env, but it allows users to build easily from a checkout. I'm not 100% sure though.

[rposts]

@kaovilai Thanks for following up on this PR. For this iteration, is it possible to release artifacts similar to this ppc64le implementation? I am unable to determine ppc64le CI is running extensive tests.

Looks like that added build support for ppc64le but explicitly disabled publishing docker images. So I think this means the testing infra does not test on this env, but it allows users to build easily from a checkout. I'm not 100% sure though.

@sseago It seems to publish binaries as well.

[kaovilai]

See if this would work for you in the meantime.

docker container create --name velero-s390x --platform=linux/s390x registry.redhat.io/oadp/oadp-velero-rhel9:1.4.0 && \
docker cp velero-s390x:/velero ./velero && \
docker container rm velero-s390x && \
docker image rm registry.redhat.io/oadp/oadp-velero-rhel9:1.4.0

you can see which tags are available at https://catalog.redhat.com/software/containers/oadp/oadp-velero-rhel9/64510133c1647dae8134a158

[rposts]

See if this would work for you in the meantime.

docker container create --name velero-s390x --platform=linux/s390x registry.redhat.io/oadp/oadp-velero-rhel9:1.4.0 && \
docker cp velero-s390x:/velero ./velero && \
docker container rm velero-s390x && \
docker image rm registry.redhat.io/oadp/oadp-velero-rhel9:1.4.0

you can see which tags are available at https://catalog.redhat.com/software/containers/oadp/oadp-velero-rhel9/64510133c1647dae8134a158

@kaovilai Yes - that works. However, this effort is to ensure we have artifacts available here as well.