velero icon indicating copy to clipboard operation
velero copied to clipboard

Add a new metric for BSL

Open chrislinan opened this issue 1 year ago • 4 comments

Describe the problem/challenge you have

Can we have a new metric for BSL to show whether BSL is valid or invalid?

Describe the solution you'd like.

add a new metric named "velero_backup_storage_location_last_status" and register this metric in the BSL controller The behavior may be like the metric "backupLastStatus"

Anything else you would like to add:

Environment:

  • Velero version (use velero version):
  • Kubernetes version (use kubectl version):
  • Kubernetes installer & version:
  • Cloud provider or hardware configuration:
  • OS (e.g. from /etc/os-release):

Vote on this issue!

This is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here.
Use the "reaction smiley face" up to the right of this comment to vote.

  • :+1: for "The project would be better with this feature added"
  • :-1: for "This feature will not enhance the project in a meaningful way"

chrislinan avatar Oct 31 '23 06:10 chrislinan

Currently we can check the status of BSL either by Velero command line interface or backuprepositories CR. Not sure if adding this new metrics would provide significant value, given these existing methods.

Let's see if there is more feedbacks from other users on this need.

allenxu404 avatar Dec 12 '23 07:12 allenxu404

@allenxu404 Actually, the BSL is the backupstoragelocations CR -- backuprepositories is used for kopia/restic for FS backup.

sseago avatar Jan 10 '24 19:01 sseago

@sseago My bad. Thanks for pointing it out.

allenxu404 avatar Jan 11 '24 01:01 allenxu404

👍

I would really like to get a metric for BackupStorageLocation and BackupSnapshotLocation too. This would make alarming much easier than implementing some job that needs to regularly use the CLI to check.

oOoHoCo avatar Mar 04 '24 10:03 oOoHoCo

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days. If a Velero team member has requested log or more information, please provide the output of the shared commands.

github-actions[bot] avatar May 04 '24 01:05 github-actions[bot]

unstale

kaovilai avatar May 05 '24 18:05 kaovilai