velero icon indicating copy to clipboard operation
velero copied to clipboard

Include all fields in marshalling of `SnapshotItemRequest` and `DeleteItemSnapshotRequest` in item_snapshotter_client.go

Open zubron opened this issue 3 years ago • 5 comments

This is a follow up from #4077.

We need to set the Params field in the SnapshotItemRequest object, and the SnapshotMetadata field in the DeleteItemSnapshotRequest in pkg/plugin/framework/item_snapshotter_client.go.

zubron avatar Nov 16 '21 21:11 zubron

@zubron I am going through all the 1.8 milestone items as requested by @reasonerjt. I assume that this is part of the data mover work and so should stay under 1.8?

eleanor-millman avatar Nov 16 '21 22:11 eleanor-millman

@eleanor-millman This is a small clean up task raised as part of #4077. It's part of the upload progress work so should stay in the 1.8 milestone.

zubron avatar Nov 17 '21 01:11 zubron

@dsu-igeek please double check if this is already done.

reasonerjt avatar Jan 21 '22 03:01 reasonerjt

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Mar 22 '22 08:03 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jul 31 '22 17:07 stale[bot]

Closing the stale issue.

stale[bot] avatar Sep 16 '22 00:09 stale[bot]