tanzu-framework icon indicating copy to clipboard operation
tanzu-framework copied to clipboard

use direct server return for azure private cluster

Open sonasingh46 opened this issue 2 years ago • 3 comments

Signed-off-by: Ashutosh Kumar [email protected]

What this PR does / why we need it

Implements direct server return.

Which issue(s) this PR fixes

Fixes #

Describe testing done for PR

Release note


Additional information

Special notes for your reviewer

sonasingh46 avatar Feb 13 '23 07:02 sonasingh46

Cluster Generation A/B Results: https://storage.googleapis.com/tkg-clustergen/4364/20230213072358/clustergen.diff.txt Author/reviewers: Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

github-actions[bot] avatar Feb 13 '23 07:02 github-actions[bot]

Cluster Generation A/B Results: https://storage.googleapis.com/tkg-clustergen/4364/20230213080829/clustergen.diff.txt Author/reviewers: Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

github-actions[bot] avatar Feb 13 '23 08:02 github-actions[bot]

Codecov Report

Merging #4364 (0e71021) into main (cd7c089) will decrease coverage by 0.91%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4364      +/-   ##
==========================================
- Coverage   49.52%   48.62%   -0.91%     
==========================================
  Files         452      482      +30     
  Lines       44986    47106    +2120     
==========================================
+ Hits        22281    22904     +623     
- Misses      20582    22027    +1445     
- Partials     2123     2175      +52     
Impacted Files Coverage Δ
...ons/controllers/packageinstallstatus_controller.go 77.99% <0.00%> (-1.16%) :arrow_down:
addons/controllers/addon_controller.go 64.43% <0.00%> (-1.04%) :arrow_down:
cmd/cli/plugin/isolated-cluster/main.go 0.00% <0.00%> (ø)
...in/cluster/get_machinehealthcheck_control_plane.go 11.11% <0.00%> (ø)
cmd/cli/plugin/cluster/machinehealthcheck.go 100.00% <0.00%> (ø)
...in/cluster/set_machinehealthcheck_control_plane.go 21.21% <0.00%> (ø)
...lugin/isolated-cluster/fakes/client_imgpkg_fake.go 32.75% <0.00%> (ø)
.../cli/plugin/cluster/set_machinehealthcheck_node.go 23.33% <0.00%> (ø)
...i/plugin/cluster/delete_machinehealthcheck_node.go 16.66% <0.00%> (ø)
cmd/cli/plugin/cluster/scale.go 17.85% <0.00%> (ø)
... and 24 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Feb 13 '23 08:02 codecov[bot]