Skip yttcc and yttcb customization check
What this PR does / why we need it
Which issue(s) this PR fixes
Fixes #4187
Describe testing done for PR
Release note
Additional information
Special notes for your reviewer
Cluster Generation A/B Results: https://storage.googleapis.com/tkg-clustergen/4180/20221215150354/clustergen.diff.txt Author/reviewers: Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.
Codecov Report
Merging #4180 (256261a) into main (1f16486) will decrease coverage by
0.76%. The diff coverage is100.00%.
@@ Coverage Diff @@
## main #4180 +/- ##
==========================================
- Coverage 49.20% 48.43% -0.77%
==========================================
Files 446 480 +34
Lines 44311 46668 +2357
==========================================
+ Hits 21803 22604 +801
- Misses 20439 21938 +1499
- Partials 2069 2126 +57
| Impacted Files | Coverage Δ | |
|---|---|---|
| tkg/tkgconfigupdater/helper.go | 46.15% <100.00%> (+0.78%) |
:arrow_up: |
| cmd/cli/plugin/feature/list.go | 81.14% <0.00%> (ø) |
|
| cmd/cli/plugin/feature/main.go | 0.00% <0.00%> (ø) |
|
| .../cli/plugin/cluster/get_machinehealthcheck_node.go | 9.30% <0.00%> (ø) |
|
| .../cli/plugin/cluster/set_machinehealthcheck_node.go | 23.33% <0.00%> (ø) |
|
| cmd/cli/plugin/cluster/get.go | 6.27% <0.00%> (ø) |
|
| cmd/cli/plugin/cluster/credentials_update.go | 8.73% <0.00%> (ø) |
|
| ...gin/isolated-cluster/imageop/publishimagestotar.go | 59.54% <0.00%> (ø) |
|
| ...in/cluster/set_machinehealthcheck_control_plane.go | 21.21% <0.00%> (ø) |
|
| cmd/cli/plugin/cluster/get_machinehealthcheck.go | 11.42% <0.00%> (ø) |
|
| ... and 28 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
Cluster Generation A/B Results: https://storage.googleapis.com/tkg-clustergen/4180/20221216065822/clustergen.diff.txt Author/reviewers: Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.
There are two funcs: GetProvidersChecksum and saveProvidersChecksumToFile that calculate ytt related checksum and compare. Please update both funcs to exclude yttcc/yttcb. More details can be found in the jira. Or the func of getFilesForChecksum are used by both funcs already?
@wjun
There are two funcs: GetProvidersChecksum and saveProvidersChecksumToFile that calculate ytt related checksum and compare. Please update both funcs to exclude yttcc/yttcb. More details can be found in the jira. Or the func of getFilesForChecksum are used by both funcs already?
For saveProvidersChecksumToFile func, it also calls GetProvidersChecksum to calculate, you can check here. After calculating the sha256, then save them.
Or the func of getFilesForChecksum are used by both funcs already?
Correct!
Hi @wjun @DanielXiao , discussed with Yang and Steven, we have another solution for TKG-15865 issue. Another pr is submitted: https://github.com/vmware-tanzu/tanzu-framework/pull/4201