fix some docker classy cluster issues
Which issue(s) this PR fixes
- Can only get one tkr in mgmt cluster on a docker cc env
kubo@0LZ8DZiMkuKTi:~$ kubectl get tkr --kubeconfig ~/.kube-tkg/config
NAME VERSION READY COMPATIBLE CREATED
v1.23.8---vmware.2-tkg.2-zshippable v1.23.8+vmware.2-tkg.2-zshippable True True 32m
expect: 3 tkrs 2. docker cluster class package reconciled failed
I1101 09:04:46.949224 1230 request.go:601] Waited for 1.016601457s due to client-side throttling, not priority and fairness, request: GET:[https://100.64.0.1:443/apis/storage.k8s.io/v1](https://100.64.0.1/apis/storage.k8s.io/v1)
kapp: Error: Ownership errors:
- Resource 'dockermachinetemplate/quick-start-control-plane (infrastructure.cluster.x-k8s.io/v1beta1) namespace: tkg-system' is already associated with a different label 'kapp.k14s.io/app=1667288342486592479'
- Resource 'dockerclustertemplate/quick-start-cluster (infrastructure.cluster.x-k8s.io/v1beta1) namespace: tkg-system' is already associated with a different label 'kapp.k14s.io/app=1667288342486592479'
- Resource 'dockermachinetemplate/quick-start-default-worker-machinetemplate (infrastructure.cluster.x-k8s.io/v1beta1) namespace: tkg-system' is already associated with a different label 'kapp.k14s.io/app=1667288342486592479'
version: 0.28.0-dev-94-g006af5a8+vmware.1
expect: reconciled successful
Cluster Generation A/B Results: https://storage.googleapis.com/tkg-clustergen/3837/20221103124000/clustergen.diff.txt Author/reviewers: Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.
Cluster Generation A/B Results: https://storage.googleapis.com/tkg-clustergen/3837/20221108082238/clustergen.diff.txt Author/reviewers: Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.
Cluster Generation A/B Results: https://storage.googleapis.com/tkg-clustergen/3837/20221108092041/clustergen.diff.txt Author/reviewers: Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.
Cluster Generation A/B Results: https://storage.googleapis.com/tkg-clustergen/3837/20221108100944/clustergen.diff.txt Author/reviewers: Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.
Codecov Report
Merging #3837 (69eb6da) into main (35982bc) will decrease coverage by
0.81%. The diff coverage is55.26%.
@@ Coverage Diff @@
## main #3837 +/- ##
==========================================
- Coverage 46.54% 45.73% -0.82%
==========================================
Files 401 426 +25
Lines 40093 41694 +1601
==========================================
+ Hits 18663 19068 +405
- Misses 19719 20899 +1180
- Partials 1711 1727 +16
| Impacted Files | Coverage Δ | |
|---|---|---|
| tkg/client/cluster.go | 15.60% <0.00%> (-0.05%) |
:arrow_down: |
| tkg/client/init.go | 0.00% <0.00%> (ø) |
|
| tkg/tkgctl/create_cluster.go | 60.36% <50.00%> (ø) |
|
| tkg/client/package_helper.go | 86.36% <53.84%> (+0.31%) |
:arrow_up: |
| tkg/tkgctl/helpers.go | 60.91% <79.06%> (+1.43%) |
:arrow_up: |
| packageclients/pkg/packageclient/package_update.go | 83.57% <0.00%> (-1.43%) |
:arrow_down: |
| ...ons/controllers/packageinstallstatus_controller.go | 77.99% <0.00%> (-1.16%) |
:arrow_down: |
| cmd/cli/plugin/cluster/get_machinehealthcheck.go | 11.42% <0.00%> (ø) |
|
| cmd/cli/plugin/cluster/delete_node_pool.go | 16.66% <0.00%> (ø) |
|
| ... and 26 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
//usebom:v1.7.0-zshippable/tkg-compatibility:v12
usebom://sandbox/v1.7.0-zshippable/433793012632422684/tkg-compatibility:v12
Is this ready to merge?