sonobuoy icon indicating copy to clipboard operation
sonobuoy copied to clipboard

`sonobuoy wait` requires `--wait` flag to be functional

Open embik opened this issue 1 year ago • 0 comments

What steps did you take and what happened:

We noticed that starting from v0.56.17 / v0.57.x, the behaviour of sonobuoy wait changed - In the "before" version, it will wait (as expected) until tests have finished or a certain timeout has been reached:

$ time ./sonobuoy wait
^C
./sonobuoy wait  0.04s user 0.01s system 0% cpu 7.950 total

In the "after" version, sonobuoy wait immediately returns with the following error:

$ time sonobuoy wait
ERRO[0000] error attempting to run sonobuoy: waiting for run to finish: context deadline exceeded
sonobuoy wait  0.03s user 0.04s system 18% cpu 0.372 total

The command only works if you pass the --wait flag, which seems like an odd "default usage".

This can be reproduced by switching between the v0.56.16 and the v0.56.17 git tag, building the binary and comparing behaviour of the command.

What did you expect to happen:

sonobuoy wait continues to exhibit consistent behaviour between patch releases.

Anything else you would like to add:

I was wondering if https://github.com/vmware-tanzu/sonobuoy/commit/f5aa6bad2515665f21597a449f618f17062d0fe6 was the culprit of this, but there isn't anything obvious in this commit that would cause this.

Environment:

  • Sonobuoy version: v0.57.1 / v0.56.17
  • Kubernetes version: (use kubectl version): v1.27.6
  • Kubernetes installer & version: Kubermatic Kubernetes Platform, v2.24.1
  • Cloud provider or hardware configuration: n/a
  • OS (e.g. from /etc/os-release): n/a
  • Sonobuoy tarball (which contains * below)

embik avatar Dec 21 '23 08:12 embik