pinniped icon indicating copy to clipboard operation
pinniped copied to clipboard

Make it easier to configure my IDP by having something better than a log statement to tell me what my upstream IDP said about me

Open ankeesler opened this issue 3 years ago • 1 comments

Is your feature request related to a problem? Please describe.

  • I've configured an upstream IDP (in my case, OIDC), and now I want to know what my upstream IDP says about me (e.g., what groups am I in? what is my username? what are my other claims (in the case of OIDC) or attributes (in the case of LDAP)? etc.)
  • Right now, I do this for OIDC via looking at the plog.LevelAll log statement, which is kinda cumbersome (although I am grateful that the log statement is there): https://github.com/vmware-tanzu/pinniped/blob/ca2ee26c8641de24f9cb65399dfe275ae1aadfcb/internal/upstreamoidc/upstreamoidc.go#L334

Describe the solution you'd like

  • @enj said ["I would like to have an API that could be used via the CLI to aid in a user determining their upstream IDP said about them (generically for all IDPs)"|https://kubernetes.slack.com/archives/C01BW364RJA/p1639064773170300?thread_ts=1639059009.168900&cid=C01BW364RJA]
  • That solution sounds like it could fit into a broader "make Pinniped easier to debug" story, which is appealing to me

Describe alternatives you've considered

  • Uh, the logging thing above, and not much else

Are you considering submitting a PR for this feature?

  • How will this project improvement be tested? TBD
  • How does this change the current architecture? TBD
  • How will this change be backwards compatible? TBD
  • How will this feature be documented? TBD

Additional context

This feature came from this discussion: https://kubernetes.slack.com/archives/C01BW364RJA/p1639059009168900

ankeesler avatar Dec 10 '21 13:12 ankeesler

Note that setting the log level to all results in the Kube code dumping all secrets, including the signing keys, into the logs. This makes such a change effectively incompatible with anything but a test environment. We really should come up with something better, perhaps as part of the upcoming auditing work?

cc @anjaltelang

enj avatar Dec 10 '21 14:12 enj