pinniped
pinniped copied to clipboard
[stub] make defensive changes to pinniped CLI to handle clock skew
As a defensive change to handle https://github.com/kubernetes/kubernetes/pull/106768 I propose that the pinniped
CLI:
- Not send
expirationTimestamp
toclient-go
/kubectl
- maybe allow this to be opt-ed into? - or a better approach may be to make sureexpirationTimestamp
is>=
totime.Now() + 10*time.Second
- Cache credentials until
expirationTimestamp
ortime.Now() + 10*time.Second
, whichever is later - (not the CLI) add a controller that detects clock skew and emits warning logs / status updates?
- We also need to fix the issue upstream which might require invasive changes and difficult to write tests