load-balancer-operator-for-kubernetes icon indicating copy to clipboard operation
load-balancer-operator-for-kubernetes copied to clipboard

Make sure static.yaml is up to date with output of `make manifests`

Open lubronzhan opened this issue 3 months ago • 0 comments

What this PR does / why we need it:

# Generate manifests e.g. CRD, RBAC etc.
manifests: $(CONTROLLER_GEN) $(KUSTOMIZE)
	$(CONTROLLER_GEN) $(CRD_OPTIONS) rbac:roleName=manager-role webhook paths="./..." output:crd:artifacts:config=config/crd/bases
	$(KUSTOMIZE) build config/kustomize-to-ytt > config/ytt/static.yaml

# Generate manifests from ytt for AKO Operator Deployment
.PHONY: ytt-manifests
ytt-manifests: $(YTT)
	@$(YTT) -v imageTag=$(BUILD_VERSION) -f config/ytt/ako-operator.yaml -f config/ytt/static.yaml -f config/ytt/values.yaml

static.yaml should be consistent with output of make manifests

it shouldn't contain the ako-operator manifetw, as you can see in ytt-manifest, it's used along with ako-operator.yaml

Which issue(s) this PR fixes:

Fixes #

Describe testing done for PR:

Special notes for your reviewer:

Release note:


New PR Checklist

  • [ ] Ensure PR contains only public links or terms
  • [ ] Use good commit messages
  • [ ] Squash the commits in this branch before merge to preserve our git history
  • [ ] If this PR is just an idea or POC, use a Draft PR instead of a full PR
  • [ ] Add appropriate labels according to what type of issue is being addressed.

lubronzhan avatar May 02 '24 22:05 lubronzhan