[velero] Default to empty volumeSnapshotLocation.

[toothbrush]

Special notes for your reviewer:

I ran into an issue where i needed to override volumeSnapshotLocation: [] in my values.yaml file, otherwise i received the following scary error:

Error: UPGRADE FAILED: post-upgrade hooks failed: unable to build kubernetes object for post-upgrade hook velero/templates/volumesnapshotlocation.yaml: error validating "": error validating data: ValidationError(VolumeSnapshotLocation.spec): missing required field "provider" in io.velero.v1.VolumeSnapshotLocation.spec

I believe that the default behaviour from v3 of the chart is preserved, because previously, leaving the value of volumeSnapshotLocation with empty values:

https://github.com/vmware-tanzu/helm-charts/blob/8f7795df79ff378a90018a2bb01d2b0652eaabcf/charts/velero/values.yaml#L280-L288

Would prevent volume snapshots from working. I think. If i understand correctly :sweat_smile:

Checklist

• [x] DCO signed
• [x] Chart Version bumped
• [x] Variables are documented in the values.yaml or README.md
• [x] Title of the PR starts with chart name (e.g. [velero])

[jenting]

@toothbrush Thanks for your contribution.

Perhaps you could change snapshotsEnabled: false in your values.yaml, without having to make code change. Please let me know if it works for you or not.

[toothbrush]

Perhaps you could change snapshotsEnabled: false in your values.yaml, without having to make code change. Please let me know if it works for you or not.

That's actually what i ended up doing, after staring more at the Helm charts 😃

However i still believe it's a bug that in the default configuration, this Helm chart (appears to) result in broken config (i.e, an invalid entry in the volumeSnapshotLocation slice).