helm-charts icon indicating copy to clipboard operation
helm-charts copied to clipboard

Add RBAC (ClusterRole,Role, RoleBinding, ClusterRoleBinding) kinds to `restoreResourcePriorities` for Velero

Open migueleliasweb opened this issue 4 years ago • 1 comments

Hi all,

I stumbled across a small problem when restoring Velero backups.

After the restore CRD is created, I've found that any Kinds (deployments, cronjobs, daemonsets, etc) that result in Pods being created, might have problems starting up their pods.

Due to the nature of the Controle Plane, Pods that rely on having access to the Kubernetes API (via RBAC config - [Cluster]Role, [Cluster]RoleBinding) to perform their work might fail to start as the Control Plane may not have had enough time to propagate RBAC related Kinds.

This can be somewhat easily fixed by adding the RBAC related Kinds in the mentioned list: https://github.com/vmware-tanzu/helm-charts/blob/master/charts/velero/values.yaml#L141

I wonder if it wouldn't make sense to make this the default behaviour?

migueleliasweb avatar Jun 01 '20 01:06 migueleliasweb

Ps: don't know wether the change you need to be made in the code itself or in the chart, since the default list in defined in: https://github.com/vmware-tanzu/velero/blob/master/pkg/cmd/server/server.go#L485

migueleliasweb avatar Jun 01 '20 01:06 migueleliasweb