crash-diagnostics icon indicating copy to clipboard operation
crash-diagnostics copied to clipboard

capture_local to support timeout?

Open reasonerjt opened this issue 3 years ago • 2 comments

I integrated crashd in my pipeline, when the test case fails this is run to collect some information:

capture_local(cmd=collectionCmd, file_name="collection.log")

Due to a bug in the backend, the case failed and the collectionCmd was blocked until the pipeline timed out and killed the whole process.

It would be friendlier for this scenario if capture_local can accept a new parm timeout so failure is more explicit.

Not sure the change should be made in this repo or gexe. I'm opening the issue here for tracking.

reasonerjt avatar Jan 28 '22 04:01 reasonerjt

@reasonerjt this is a good idea. I think all commands that interact with a resource (compute, local or remote) should support a timeout value.

vladimirvivien avatar Feb 02 '22 16:02 vladimirvivien

@vladimirvivien, bumping this discussion, we would like to utilize the timeout feature as well, because we have observed occasions when crashd would hang for hours collecting logs from specific resources.

klxfeiyang avatar Mar 09 '22 23:03 klxfeiyang