cluster-api-provider-bringyourownhost icon indicating copy to clipboard operation
cluster-api-provider-bringyourownhost copied to clipboard

Observability for BYOH - Task 1, 2

Open Shubbhang351 opened this issue 2 years ago • 1 comments

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Additional information Observability for BYOH

Special notes for your reviewer

Shubbhang351 avatar Jul 26 '22 06:07 Shubbhang351

@Shubbhang351, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

vmwclabot avatar Jul 26 '22 06:07 vmwclabot

Thanks @shubham14bajpai for the changes, If you are working on this, then can you please raise the PR ?

shivi28 avatar Nov 19 '22 03:11 shivi28

Hey @shivi28, @Shubbhang351 was working on this for a hackathon, if he no longer has cycles to finish this I could take this up :slightly_smiling_face:

shubham14bajpai avatar Nov 19 '22 07:11 shubham14bajpai

@shubham14bajpai, my apologies for incorrectly pinging you. But if you have bandwidth and you are interested, then feel free to pick this issue. :) . @Shubbhang351 let us know if you are still interested to work on it.

shivi28 avatar Nov 21 '22 03:11 shivi28

Hi @shivi28, This PR can be merged in the target branch(i.e. feature-observability-branch). Later, this requires reprioritizing and re-consensus of this feature before pushing it to the main. We would need actual use cases where this feature might add value.

dharmjit avatar Nov 21 '22 04:11 dharmjit

Sure @dharmjit , so should we aim to merge it in target branch now ?

shivi28 avatar Nov 23 '22 06:11 shivi28