cluster-api-provider-bringyourownhost
cluster-api-provider-bringyourownhost copied to clipboard
BYOH cluster is in provisioned state when control plane is not online
What steps did you take and what happened:
When trying to setup BYOH
cluster, the cluster state fetched in kubectl get cluster
is provisioned
even when the control plane is not online. This might be confusing in case the control plane takes a long time to start or fails to start.
What did you expect to happen:
I expected to see the cluster state provisioned
only when the control plane is up and running.
Anything else you would like to add:
I found that the cluster state is marked provisioned on basis of InfrastructureReady
condition and a valid ControlPlaneEndpoint
[here]. It seems like in byocluster_controller, we are not waiting for the control plane to become available. We could look at vSphere implementation for reference.
Environment:
- Cluster-api-provider-bringyourownhost version: v0.1.0
- Kubernetes version: (use
kubectl version --short
): v1.22.3 - OS (e.g. from
/etc/os-release
): Ubuntu 20.04