Investigate why /lgtm label is not working

[shamsher31]

What steps did you take and what happened: Add /lgtm label to any PR. You will see the following error.

Error: error handling issue comment: Error: commenter is not a org member or collaborator. Cannot add lgtm label

See https://github.com/vmware-tanzu/cluster-api-provider-bringyourownhost/actions/runs/1490117401

What did you expect to happen: If /lgtm label is present along with /approve, the PR should merge automatically.

Anything else you would like to add: The problem might be because of org label or reviewer group is not specified anywhere in merge actions.

[Akasurde]

@shamsher31 lgtm chat command uses API checkMembership in the current code base of https://github.com/jpmcb/prow-github-actions but this API is changed to checkMembershipForUser.

I raised a PR https://github.com/jpmcb/prow-github-actions/pull/37 to modify this API as per the new version. Let us wait to get this PR merged.

[jpmcb]

Thanks for surfacing this!

The prow bot is actually using an older version of @actions/github and the checkMembershipForUser API wasn't added until a later version. The currently implementation should still work.

I do see that you are a member of this org where you had commented the lgtm label command. But i don't think the error gets surfaced out of the checkMembership job when there's problems. I think that's the first thing to do since GitHub org authentication can be really really tricky.

For reference:

• [ ] https://github.com/jpmcb/prow-github-actions/issues/39